Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

community[patch]: Astra updates #5218

Merged
merged 6 commits into from
May 10, 2024
Merged

community[patch]: Astra updates #5218

merged 6 commits into from
May 10, 2024

Conversation

mfortman11
Copy link
Contributor

@mfortman11 mfortman11 commented Apr 25, 2024 •
edited
Loading

workerB

Utilizes new astra client features

Add Docs now updates docs w/ the same ids

@vercel Vercel
Copy link

vercel bot commented Apr 25, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
langchainjs-api-refs ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 10, 2024 7:52pm
langchainjs-docs ✅ Ready (Inspect) Visit Preview May 10, 2024 7:52pm

@mfortman11 mfortman11 changed the title Astra updates community[patch]: Astra updates Apr 25, 2024
@mfortman11 mfortman11 marked this pull request as ready for review April 26, 2024 15:43
@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. auto:improvement Medium size change to existing code to handle new use-cases labels Apr 26, 2024
@jacoblee93
Copy link
Collaborator

Looks good! Can you mark batchSize as deprecated to let them know that it no longer has an effect?

@jacoblee93 jacoblee93 added the close PRs that need one or two touch-ups to be ready label Apr 26, 2024
@mfortman11
Copy link
Contributor Author

All set

bracesproul
bracesproul approved these changes May 3, 2024
View reviewed changes
Copy link
Member

@bracesproul bracesproul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tyvm!

@dosubot dosubot bot added the lgtm PRs that are ready to be merged as-is label May 3, 2024
@bracesproul bracesproul removed the close PRs that need one or two touch-ups to be ready label May 3, 2024
bracesproul
bracesproul reviewed May 6, 2024
View reviewed changes
Copy link
Member

@bracesproul bracesproul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like CI is failing, could you fix and re-request my review so I can merge?

@bracesproul bracesproul removed the lgtm PRs that are ready to be merged as-is label May 6, 2024
@mfortman11
Copy link
Contributor Author

mfortman11 commented May 9, 2024 •
edited
Loading

@bracesproul sorry for the delay the the issue appears to be around batchSize with this change it is no longer need so i added the deprecated note to it per Jacobs request but that is the cause of the build error

/** @deprecated astra-db-ts > 1.0.0 handles this */
  private readonly batchSize: number;

Lmk how i should handle this

bracesproul
bracesproul approved these changes May 10, 2024
View reviewed changes
Copy link
Member

@bracesproul bracesproul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just pushed a commit doing two things:

  1. dropped the batchSize class property. Since it was already marked as private readonly deleting it won't be breaking for anyone.
  2. I added a console.warn notifying users that passing in the batchSize arg has no effect anymore.

Thanks for doing this! Going to get it merged asap

@dosubot dosubot bot added the lgtm PRs that are ready to be merged as-is label May 10, 2024
@bracesproul bracesproul merged commit 64fe671 into langchain-ai:main May 10, 2024
17 checks passed
@aechegoyan17 aechegoyan17 mentioned this pull request Jun 6, 2024
Open
@riderx riderx mentioned this pull request Jun 9, 2024
Closed
This was referenced Jun 11, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bracesproul bracesproul bracesproul approved these changes

Assignees
No one assigned
Labels
auto:improvement Medium size change to existing code to handle new use-cases lgtm PRs that are ready to be merged as-is size:M This PR changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mfortman11 @jacoblee93 @bracesproul