Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

langchain[patch]: Make DynamicRunEvaluatorParams generic #5246

Merged
merged 2 commits into from
Apr 30, 2024
Merged

langchain[patch]: Make DynamicRunEvaluatorParams generic #5246

merged 2 commits into from
Apr 30, 2024

Conversation

davidfant
Copy link
Contributor

Currently I'm doing this kind of dirty type casting in my code, which I want to avoid

const input = params.input as unknown as MyInput;
const prediction = (params.prediction as MyPred | undefined)?.someKnownField

@dosubot dosubot bot added the size:S This PR changes 10-29 lines, ignoring generated files. label Apr 29, 2024
@vercel Vercel
Copy link

vercel bot commented Apr 29, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
langchainjs-api-refs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 29, 2024 11:59pm
langchainjs-docs ✅ Ready (Inspect) Visit Preview Apr 29, 2024 11:59pm

@dosubot dosubot bot added the auto:improvement Medium size change to existing code to handle new use-cases label Apr 29, 2024
bracesproul
bracesproul approved these changes Apr 29, 2024
View reviewed changes
Copy link
Member

@bracesproul bracesproul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, this will be good. Ty for doing this!

cc @hinthornw

@dosubot dosubot bot added the lgtm PRs that are ready to be merged as-is label Apr 29, 2024
@bracesproul bracesproul changed the title Make DynamicRunEvaluatorParams generic langchain[patch]: Make DynamicRunEvaluatorParams generic Apr 29, 2024
@bracesproul bracesproul merged commit 52007ab into langchain-ai:main Apr 30, 2024
17 checks passed
@davidfant davidfant deleted the types/langsmith-evaluator branch April 30, 2024 13:56
@aechegoyan17 aechegoyan17 mentioned this pull request Jun 6, 2024
Open
@riderx riderx mentioned this pull request Jun 9, 2024
Closed
This was referenced Jun 11, 2024
Merged
Merged
@Avish24x Avish24x mentioned this pull request Jun 20, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bracesproul bracesproul bracesproul approved these changes

Assignees
No one assigned
Labels
auto:improvement Medium size change to existing code to handle new use-cases lgtm PRs that are ready to be merged as-is size:S This PR changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@davidfant @bracesproul