Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

scripts[minor]: Fix executable #5268

Merged
merged 3 commits into from
May 2, 2024
Merged

scripts[minor]: Fix executable #5268

merged 3 commits into from
May 2, 2024

Conversation

bracesproul
Copy link
Member

No description provided.

@vercel Vercel
Copy link

vercel bot commented May 2, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
langchainjs-api-refs ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 2, 2024 0:46am
langchainjs-docs ✅ Ready (Inspect) Visit Preview May 2, 2024 0:46am

@bracesproul bracesproul marked this pull request as ready for review May 2, 2024 01:00
@dosubot dosubot bot added the size:XL This PR changes 500-999 lines, ignoring generated files. label May 2, 2024
@bracesproul bracesproul merged commit 24ab2a6 into main May 2, 2024
17 checks passed
@bracesproul bracesproul deleted the brace/fix-scripts-exec branch May 2, 2024 01:00
dosubot[bot]
dosubot bot reviewed May 2, 2024
View reviewed changes
libs/langchain-scripts/package.json
@@ -46,7 +46,7 @@
"glob": "^10.3.10",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey there! I noticed the change in the TypeScript dependency from "<5.2.0" to "^5.4.5" in the package.json file, which impacts the hard dependency of the project. I've flagged this for your review as it expands the acceptable range of TypeScript versions. Keep up the great work!

@underwater
Copy link

Hi, I am getting a TypeError [ERR_UNKNOWN_FILE_EXTENSION]" error which is breaking the build after this P/R.
This happens in both windows and linux with or without the .dev container environment....
Is this a bug ?

@underwater
Copy link

Just updated my node version from 20.9.0 to 20.13.1 and the build seems alright....
So
yarn build breaks in langchain-core using node 20.9.0
yarn build is fine in langchain-core using node 20.13.1

@TeCHiScy
Copy link
Contributor

same here, Node.js v20.9.0 failed with error ERR_UNKNOWN_FILE_EXTENSION.

@aechegoyan17 aechegoyan17 mentioned this pull request Jun 6, 2024
Open
@riderx riderx mentioned this pull request Jun 9, 2024
Closed
This was referenced Jun 11, 2024
Merged
Merged
@Avish24x Avish24x mentioned this pull request Jun 20, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dosubot dosubot[bot] dosubot[bot] left review comments

Assignees
No one assigned
Labels
size:XL This PR changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bracesproul @underwater @TeCHiScy