-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
qdrant[major]: Add @langchain/qdrant
Package
#5302
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
@@ -0,0 +1,93 @@ | |||
{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey there! 👋 This PR adds new dependencies to the project, including both peer and dev dependencies. I've flagged this for your review to ensure the changes align with the project's requirements. Keep up the great work! 🚀
@@ -0,0 +1,53 @@ | |||
/* eslint-disable no-process-env */ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey there! I noticed that the recent code changes involve accessing environment variables via process.env
. This comment is just to flag this change for your review. Let me know if you have any questions or need further assistance with this.
@@ -0,0 +1,304 @@ | |||
import { QdrantClient } from "@qdrant/js-client-rest"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey team, I've reviewed the code changes and flagged a comment on the PR to highlight the addition of code that explicitly reads environment variables using the getEnvironmentVariable
function. This change should be reviewed by maintainers to ensure proper handling of environment variables.
@langchain/qdrant
Package
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for doing this! I pushed up some small commits with nits, but besides that lgtm!
Description
This PR adds a
@langchain/qdrant
package based on the current community implementation.