Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

qdrant[major]: Add @langchain/qdrant Package #5302

Merged
merged 3 commits into from
May 7, 2024

Conversation

Anush008
Copy link
Contributor

@Anush008 Anush008 commented May 7, 2024

Description

This PR adds a @langchain/qdrant package based on the current community implementation.

@dosubot dosubot bot added the size:XL This PR changes 500-999 lines, ignoring generated files. label May 7, 2024
Copy link

vercel bot commented May 7, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
langchainjs-api-refs ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 7, 2024 8:37pm
langchainjs-docs ✅ Ready (Inspect) Visit Preview May 7, 2024 8:37pm

@dosubot dosubot bot added the auto:enhancement A large net-new component, integration, or chain. Use sparingly. The largest features label May 7, 2024
@@ -0,0 +1,93 @@
{
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey there! 👋 This PR adds new dependencies to the project, including both peer and dev dependencies. I've flagged this for your review to ensure the changes align with the project's requirements. Keep up the great work! 🚀

@@ -0,0 +1,53 @@
/* eslint-disable no-process-env */
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey there! I noticed that the recent code changes involve accessing environment variables via process.env. This comment is just to flag this change for your review. Let me know if you have any questions or need further assistance with this.

@@ -0,0 +1,304 @@
import { QdrantClient } from "@qdrant/js-client-rest";
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey team, I've reviewed the code changes and flagged a comment on the PR to highlight the addition of code that explicitly reads environment variables using the getEnvironmentVariable function. This change should be reviewed by maintainers to ensure proper handling of environment variables.

@bracesproul bracesproul changed the title @langchain/qdrant Package qdrant[major]: Add @langchain/qdrant Package May 7, 2024
Copy link
Member

@bracesproul bracesproul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this! I pushed up some small commits with nits, but besides that lgtm!

@dosubot dosubot bot added the lgtm PRs that are ready to be merged as-is label May 7, 2024
@bracesproul bracesproul merged commit 65729fb into langchain-ai:main May 7, 2024
21 checks passed
@Anush008 Anush008 deleted the langchain-qdrant branch May 7, 2024 23:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto:enhancement A large net-new component, integration, or chain. Use sparingly. The largest features lgtm PRs that are ready to be merged as-is size:XL This PR changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants