Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

langchain[patch]: Remove outdated test #5347

Merged
merged 1 commit into from
May 13, 2024
Merged

langchain[patch]: Remove outdated test #5347

merged 1 commit into from
May 13, 2024
+8 −42

Conversation

jacoblee93
Copy link
Collaborator

@jacoblee93
Remove outdated test

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
Loading
Loading status checks…
cc7b710
@vercel Vercel
Copy link

vercel bot commented May 13, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
langchainjs-api-refs ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 13, 2024 11:07pm
langchainjs-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 13, 2024 11:07pm

@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. auto:nit Small modifications/deletions, fixes, deps or improvements to existing code or docs labels May 13, 2024
bracesproul
bracesproul approved these changes May 13, 2024
View reviewed changes
Copy link
Member

@bracesproul bracesproul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, only other thing is I think we can also remove the code inside gh actions which passes COHERE_API_KEY through the envs?

@dosubot dosubot bot added the lgtm PRs that are ready to be merged as-is label May 13, 2024
@jacoblee93 jacoblee93 merged commit a57d58e into main May 13, 2024
17 checks passed
@jacoblee93 jacoblee93 deleted the jacob/deps branch May 13, 2024 23:09
@cnkang cnkang mentioned this pull request Jun 11, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bracesproul bracesproul

Assignees
No one assigned
Labels
auto:nit Small modifications/deletions, fixes, deps or improvements to existing code or docs lgtm PRs that are ready to be merged as-is size:M This PR changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jacoblee93 @bracesproul