-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
core[patch]: Adding raiseError Field to Callbacks #5373
Merged
jacoblee93
merged 5 commits into
langchain-ai:main
from
CahidArda:core-callback-raise-error
May 15, 2024
Merged
core[patch]: Adding raiseError Field to Callbacks #5373
jacoblee93
merged 5 commits into
langchain-ai:main
from
CahidArda:core-callback-raise-error
May 15, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
These errors will be uncatchable if backgrounding is enabled - I think it'd be reasonable to make a callback awaited if this condition is true. |
…core-callback-raise-error
@baskaryan can you take a quick look? |
@CahidArda will aim to ship this next week as part of 0.2 - if you have a burning need for it sooner, I can cherry pick and cut a 0.1.x core release |
This was referenced May 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
auto:improvement
Medium size change to existing code to handle new use-cases
lgtm
PRs that are ready to be merged as-is
size:L
This PR changes 100-499 lines, ignoring generated files.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi there!
We want to add a callback to manage rate limiting based on the number of requests or the number of tokens. For this to work, callback needs to be able to stop the execution of the chain. This is not possible in LangChain Js, while it is possible in LangChain Python (see
raise_error
field). In LangChain Js, the error is simply logged but the chain continues.To make this possible, we update the
BaseRunManager
and its subclasses by throwing the error if the newraiseError
field of the handler istrue
.To give you an idea about the rate limiting callback we want to add to LangChain under community, here is a code sample:
Ratelimiting Callback