Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(google-genai): use correct base url and set correct constructor props #5483

Closed

Conversation

yharaskrik
Copy link

Fixes #5437

Copy link

vercel bot commented May 20, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
langchainjs-api-refs ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 20, 2024 5:46pm
langchainjs-docs ✅ Ready (Inspect) Visit Preview May 20, 2024 5:46pm

@dosubot dosubot bot added size:S This PR changes 10-29 lines, ignoring generated files. auto:bug Related to a bug, vulnerability, unexpected error with an existing feature labels May 20, 2024
@@ -239,6 +244,11 @@ export class ChatGoogleGenerativeAI
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey there! I've flagged the recent change in the PR for maintainers to review, as it explicitly accesses an environment variable via getEnvironmentVariable. Please take a look and let me know if you need further assistance!

@bracesproul
Copy link
Member

This was fixed by #5490

@yharaskrik
Copy link
Author

This was fixed by #5490

Yup, yours wasn't open when I opened mine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto:bug Related to a bug, vulnerability, unexpected error with an existing feature size:S This PR changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Endpoint issue with Gemini Pro 1.5 and Gemini Flash Support
2 participants