Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci[patch]: fix unit-tests-integrations by implementing dynamic matrix strategy. #5768

Merged
merged 11 commits into from
Jun 25, 2024
Merged

Conversation

rameshkrishna
Copy link
Contributor

@rameshkrishna rameshkrishna commented Jun 15, 2024

  • get-changed-files: Determines the files changed in the latest commit.
  • prepare-matrix: Generates a matrix strategy for packages that have changed and need testing.
  • unit-tests: Runs the unit tests for the identified packages on Node.js versions 18 and 20 incase of no changes in unit test jobs is skipped and whole workflow gets marked as success.

Copy link

vercel bot commented Jun 15, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
langchainjs-api-refs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 25, 2024 5:37pm
langchainjs-docs ✅ Ready (Inspect) Visit Preview Jun 25, 2024 5:37pm

@rameshkrishna rameshkrishna marked this pull request as ready for review June 15, 2024 05:12
@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. auto:improvement Medium size change to existing code to handle new use-cases labels Jun 15, 2024
@bracesproul
Copy link
Member

What issue is this fixing? @rameshkrishna

@rameshkrishna
Copy link
Contributor Author

Hey @bracesproul,

This PR addresses the unit tests langchain integrations workflow failures caused by the changes introduced in PR ci[patch]: Only run CI testing if specific package touched 5733.

Failures in this github workflow : https://github.com/langchain-ai/langchainjs/actions/workflows/unit-tests-integrations.yml

Here is the error message when the above work flow is triggered

Annotations

1 error
Invalid workflow file: .github/workflows/unit-tests-integrations.yml#L59The workflow is not valid. .github/workflows/unit-tests-integrations.yml (Line: 59, Col: 9): Unrecognized named-value: 'matrix'. Located at position 1 within expression: matrix.packageShow less -- Annotations 1 error [Invalid workflow file: .github/workflows/unit-tests-integrations.yml#L59](https://github.com/langchain-ai/langchainjs/actions/runs/9488089685/workflow) The workflow is not valid. .github/workflows/unit-tests-integrations.yml (Line: 59, Col: 9): Unrecognized named-value: 'matrix'. Located at position 1 within expression: matrix.package

@rameshkrishna
Copy link
Contributor Author

More details here #5812

@dosubot dosubot bot added size:XXL This PR changes 1000+ lines, ignoring generated files. and removed size:M This PR changes 30-99 lines, ignoring generated files. labels Jun 20, 2024
@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. and removed size:XXL This PR changes 1000+ lines, ignoring generated files. labels Jun 20, 2024
@jacoblee93
Copy link
Collaborator

CC @bracesproul is this still needed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto:improvement Medium size change to existing code to handle new use-cases size:M This PR changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants