Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azure-dynamic-sessions[major]: Add new package #5788

Merged
merged 25 commits into from
Jun 21, 2024

Conversation

anthonychu
Copy link
Contributor

Add a new @langchain/azure-dynamic-sessions package that provides a Python code interpreter tool using code interpreter sandboxes in Azure Container Apps dynamic sessions.

@dosubot dosubot bot added the size:XL This PR changes 500-999 lines, ignoring generated files. label Jun 17, 2024
Copy link

vercel bot commented Jun 17, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
langchainjs-api-refs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 21, 2024 9:29pm
langchainjs-docs ✅ Ready (Inspect) Visit Preview Jun 21, 2024 9:29pm

@dosubot dosubot bot added auto:documentation Changes to documentation and examples, like .md, .rst, .ipynb files. Changes to the docs/ folder auto:enhancement A large net-new component, integration, or chain. Use sparingly. The largest features labels Jun 17, 2024
@@ -0,0 +1,43 @@
import type { ChatPromptTemplate } from "@langchain/core/prompts";
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey there! 👋 I noticed that the recent code changes in azure_dynamic_sessions-agent.ts explicitly access an environment variable using process.env. I've flagged this for your review to ensure it aligns with our environment variable usage guidelines. Keep up the great work! 🚀

@@ -0,0 +1,16 @@
import { SessionsPythonREPLTool } from "@langchain/azure-dynamic-sessions";
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey team, I've flagged a change in the PR for the azure_dynamic_sessions.ts file that explicitly accesses an environment variable via process.env. Please review this change to ensure it aligns with our environment variable usage guidelines.

@@ -0,0 +1,92 @@
{
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey team, I've noticed that this PR includes changes to the dependencies, including additions and version constraints. This is flagged for your review to ensure the changes align with our dependency management strategy. Great work overall!

@@ -0,0 +1,135 @@
import { test, jest, describe, beforeEach } from "@jest/globals";
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey team, I've reviewed the code and noticed a new external HTTP request using fetch in the "Invoke with Python code" test. This comment is to flag the change for maintainers to review and ensure it aligns with the project's requirements.

@@ -0,0 +1,260 @@
import { promises as fs } from "node:fs";
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey team, just wanted to flag that this PR introduces new external HTTP requests using the fetch function. These requests are for making POST and GET requests to API endpoints, so it's important for maintainers to review this change. Let me know if you have any questions or need further clarification!

@jacoblee93 jacoblee93 changed the title azure-dynamic-sessions: Add new package azure-dynamic-sessions[major]: Add new package Jun 18, 2024
}

const data = await fs.readFile(
path.join(currentDir, "..", "package.json"),
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure if this will work after build etc. in all environments - have been meaning to make this a formal API. Can we remove and readd later?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Or just hardcode as a constant for now? Since it's just going to be 0.0.1

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

const userAgentPrefix = "langchainjs-azure-dynamic-sessions";

let userAgent = "";
async function getuserAgentSuffix(): Promise<string> {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: camel case

@jacoblee93
Copy link
Collaborator

This is really neat! A few nits but seems good to me

@sinedied
Copy link
Contributor

@jacoblee93 I've made the fixes, should be good now

@jacoblee93
Copy link
Collaborator

Thank you!

@jacoblee93
Copy link
Collaborator

This is live on npm as 0.1.0: https://www.npmjs.com/package/@langchain/azure-dynamic-sessions

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto:documentation Changes to documentation and examples, like .md, .rst, .ipynb files. Changes to the docs/ folder auto:enhancement A large net-new component, integration, or chain. Use sparingly. The largest features close PRs that need one or two touch-ups to be ready size:XL This PR changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants