cohere[minor]: Add support for tool calling cohere #5810

Anirudh31415926535 · 2024-06-19T11:14:32Z

This PR supports tool calling in js for cohere models.

High level feature introductions:

Parse chat history parameter in request to now include tool messages
Handle parsing logic separately as required for multi hop tool calling and single step tool calling
Add tests to ensure tool calling works as expected
Bump default model version to 'command-r-plus'
Relevant doc changes to remove hardcoded 'model=command' and to showcase tool calling support

vercel · 2024-06-19T11:14:35Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
langchainjs-api-refs	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jul 9, 2024 7:14pm
langchainjs-docs	✅ Ready (Inspect)	Visit Preview		Jul 9, 2024 7:14pm

dosubot · 2024-06-19T11:16:47Z

examples/src/models/chat/cohere/tool_calling.ts

@@ -0,0 +1,79 @@
+import { ChatCohere } from "@langchain/cohere";


Hey there! 👋 This is a friendly flag to highlight that the recent code change explicitly accesses an environment variable using process.env. This is an important point for maintainers to review. Keep up the great work! 🚀

dosubot · 2024-06-19T11:16:48Z

libs/langchain-cohere/package.json

@@ -36,7 +36,8 @@
  "license": "MIT",


Hey there! I noticed that a new dependency "zod" has been added to the "dependencies" section, which is a change in the project's dependencies. This comment is to flag the change for maintainers to review. Great work!

dosubot · 2024-06-19T11:16:49Z

package.json

@@ -69,5 +69,9 @@
      "eslint --cache --fix"


Hey there! 👋 I noticed that this PR adds new dependencies ("jest-cli" and "zod") to the project's "dependencies" section in package.json. This is flagged for your review to ensure the impact of these changes, whether they are peer, dev, or hard dependencies. Keep up the great work! 🚀

jacoblee93 · 2024-06-21T22:08:47Z

langchain-core/tsconfig.json

@@ -9,7 +9,7 @@
      "ES2022.Object",
      "DOM"
    ],
-    "module": "ES2020",
+    "module": "NodeNext",


Can you revert these? Should not be in this PR.

jacoblee93 · 2024-06-21T22:08:56Z

libs/langchain-cohere/package.json

@@ -25,7 +25,7 @@
    "test": "NODE_OPTIONS=--experimental-vm-modules jest --testPathIgnorePatterns=\\.int\\.test.ts --testTimeout 30000 --maxWorkers=50%",
    "test:watch": "NODE_OPTIONS=--experimental-vm-modules jest --watch --testPathIgnorePatterns=\\.int\\.test.ts",
    "test:single": "NODE_OPTIONS=--experimental-vm-modules yarn run jest --config jest.config.cjs --testTimeout 100000",
-    "test:int": "NODE_OPTIONS=--experimental-vm-modules jest --testPathPattern=\\.int\\.test.ts --testTimeout 100000 --maxWorkers=50%",
+    "test:int": "NODE_OPTIONS=--experimental-vm-modules jest --testPathPattern=\\chat_models.int\\.test.ts --testTimeout 100000 --maxWorkers=50%",


jacoblee93 · 2024-06-21T22:09:35Z

package.json

@@ -69,5 +69,9 @@
      "eslint --cache --fix"
    ],
    "*.md": "prettier --config .prettierrc --write"
+  },
+  "dependencies": {
+    "jest-cli": "^29.7.0",


jacoblee93 · 2024-06-21T22:11:29Z

libs/langchain-cohere/src/chat_models.ts

@@ -135,7 +196,7 @@ export class ChatCohere<

  client: CohereClient;

-  model = "command";
+  model = "command-r-plus";


This is technically breaking

if we're going to break here, can we make model a required param

Hey @billytrend-cohere We're making the model a required param for Embedding, and Reranker. Imo it is better to leave model as a non-required param for chat, since the implication of an unforeseen model bump isn't huge compared to embedding/rerank.

Would still prefer this to be required (look at what happened with gpt-4o) but if you feel strongly I'm fine with keeping it.

jacoblee93 · 2024-06-21T22:12:52Z

Thanks for this!

Could you try scoping the changes down a bit? Appears to be a lot of unrelated diffs.

Also, don't forget to run yarn format and yarn lint!

jacoblee93 · 2024-07-02T23:44:47Z

libs/langchain-cohere/src/chat_models.ts

@@ -445,3 +762,5 @@ export class ChatCohere<
 interface CohereLLMOutput {
  estimatedTokenUsage?: TokenUsage;
 }
+
+/* eslint-enable  @typescript-eslint/no-explicit-any */


Not necessary

libs/langchain-cohere/src/chat_models.ts

jacoblee93 · 2024-07-02T23:45:51Z

libs/langchain-cohere/src/chat_models.ts

+    return req;
+  }
+
+  getCurrChatTurnMessages(messages: BaseMessage[]): BaseMessage[] {


See above, you might also consider adding this as a function outside of the class:

https://github.com/langchain-ai/langchainjs/blob/main/libs/langchain-anthropic/src/chat_models.ts#L105

But these helper methods definitely shouldn't be public

jacoblee93 · 2024-07-02T23:48:54Z

libs/langchain-cohere/src/chat_models.ts

You should also add a override bindTools() method, it'll make this support other methods for free:

https://github.com/langchain-ai/langchainjs/blob/main/libs/langchain-anthropic/src/chat_models.ts#L589

jacoblee93 · 2024-07-02T23:49:10Z

libs/langchain-cohere/src/chat_models.ts

+    // eslint-disable-next-line no-instanceof/no-instanceof
+    message instanceof HumanMessage ||
+    // eslint-disable-next-line no-instanceof/no-instanceof
+    message instanceof SystemMessage


Use e.g. message._getType() === "human" instead.

Anirudh31415926535 · 2024-07-08T06:56:24Z

@jacoblee93 Hey, thanks so much for the review and comments! I've addressed them! Could you please help to take a look again if possible and then we can try to see if we can get this PR and the other one released by this week? Thanks so much! 💯

jacoblee93 · 2024-07-09T17:03:24Z

Yes will look today, thanks for the hard work!

…5810

jacoblee93 · 2024-07-09T18:53:33Z

Pushed some refactoring/lint/format stuff, will merge alongside the embedding PR and minor bump the package.

jacoblee93 · 2024-07-09T19:19:28Z

Thank you!

feat: Add support for tool calling cohere

36f86ea

dosubot bot added size:XL This PR changes 500-999 lines, ignoring generated files. auto:enhancement A large net-new component, integration, or chain. Use sparingly. The largest features labels Jun 19, 2024

dosubot bot reviewed Jun 19, 2024

View reviewed changes

vercel bot deployed to Preview – langchainjs-api-refs June 19, 2024 11:21 View deployment

vercel bot deployed to Preview – langchainjs-docs June 19, 2024 11:22 View deployment

fix: lint errors + minor fixes

6de2f8e

vercel bot deployed to Preview – langchainjs-api-refs June 20, 2024 05:41 View deployment

vercel bot deployed to Preview – langchainjs-docs June 20, 2024 05:42 View deployment

jacoblee93 reviewed Jun 21, 2024

View reviewed changes

Anirudh31415926535 added 3 commits June 24, 2024 14:56

fix: apply format and lint, revert some unexpected changes to json files

8d98b04

Update tsconfig.json

2442d5a

Remove added deps from package json file

100e7ef

vercel bot had a problem deploying to Preview – langchainjs-api-refs June 24, 2024 07:03 Failure

vercel bot had a problem deploying to Preview – langchainjs-docs June 24, 2024 07:04 Failure

nit: Fix typo

1f7f7e1

vercel bot had a problem deploying to Preview – langchainjs-docs June 28, 2024 17:07 Failure

vercel bot had a problem deploying to Preview – langchainjs-api-refs June 28, 2024 17:07 Failure

jacoblee93 reviewed Jul 2, 2024

View reviewed changes

libs/langchain-cohere/src/chat_models.ts Show resolved Hide resolved

jacoblee93 reviewed Jul 2, 2024

View reviewed changes

billytrend-cohere approved these changes Jul 4, 2024

View reviewed changes

Anirudh31415926535 added 5 commits July 5, 2024 16:35

address PR comments

bb5d9a3

make methods private

77d3f46

Merge branch 'main' into anirudh/support-tool-calling-cohere

834addc

update yarn lock

827cfc0

nit

f7debe4

vercel bot deployed to Preview – langchainjs-api-refs July 6, 2024 15:52 View deployment

vercel bot deployed to Preview – langchainjs-docs July 6, 2024 15:52 View deployment

jacoblee93 changed the title ~~feat: Add support for tool calling cohere~~ cohere[minor]: Add support for tool calling cohere Jul 9, 2024

jacoblee93 added 3 commits July 9, 2024 10:22

Merge branch 'main' of https://github.com/hwchase17/langchainjs into …

457d6fa

…5810

Lint, support OpenAI tool schemas

3ff35b8

Fix and enable standard tool calling tests

41c8210

jacoblee93 added lgtm PRs that are ready to be merged as-is hold On hold labels Jul 9, 2024

vercel bot deployed to Preview – langchainjs-api-refs July 9, 2024 18:59 View deployment

vercel bot deployed to Preview – langchainjs-docs July 9, 2024 19:01 View deployment

Bump lower-bound dep

aa82799

jacoblee93 removed the hold On hold label Jul 9, 2024

vercel bot deployed to Preview – langchainjs-docs July 9, 2024 19:14 View deployment

vercel bot deployed to Preview – langchainjs-api-refs July 9, 2024 19:14 View deployment

jacoblee93 merged commit 73ee114 into langchain-ai:main Jul 9, 2024
37 checks passed

prathik2401 mentioned this pull request Jul 31, 2024

[Snyk] Upgrade langchain from 0.2.8 to 0.2.9 prathik2401/sentilog-deploy#10

Merged

abdulrahman305 mentioned this pull request Aug 1, 2024

[Snyk] Upgrade langchain from 0.0.96 to 0.2.9 abdulrahman305/langchain-chatbot-demo#11

Open

This was referenced Aug 2, 2024

[Snyk] Upgrade langchain from 0.0.156 to 0.2.9 askrella/whatsapp-chatgpt#354

Open

[Snyk] Upgrade langchain from 0.0.156 to 0.2.9 askrella/whatsapp-chatgpt#357

Open

filipeoliveiraa mentioned this pull request Aug 4, 2024

[Snyk] Upgrade langchain from 0.0.123 to 0.2.9 filipeoliveiraa/azurechatgpt#5

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

cohere[minor]: Add support for tool calling cohere #5810

cohere[minor]: Add support for tool calling cohere #5810

Anirudh31415926535 commented Jun 19, 2024 •

edited

Loading

vercel bot commented Jun 19, 2024 •

edited

Loading

dosubot bot Jun 19, 2024

dosubot bot Jun 19, 2024

dosubot bot Jun 19, 2024

jacoblee93 Jun 21, 2024

jacoblee93 Jun 21, 2024

jacoblee93 Jun 21, 2024

jacoblee93 Jun 21, 2024

billytrend-cohere Jul 4, 2024

Anirudh31415926535 Jul 6, 2024

jacoblee93 Jul 9, 2024

jacoblee93 commented Jun 21, 2024

jacoblee93 Jul 2, 2024

jacoblee93 Jul 2, 2024 •

edited

Loading

jacoblee93 Jul 2, 2024

jacoblee93 Jul 2, 2024

Anirudh31415926535 commented Jul 8, 2024

jacoblee93 commented Jul 9, 2024

jacoblee93 commented Jul 9, 2024

jacoblee93 commented Jul 9, 2024

		@@ -0,0 +1,79 @@
		import { ChatCohere } from "@langchain/cohere";

cohere[minor]: Add support for tool calling cohere #5810

cohere[minor]: Add support for tool calling cohere #5810

Conversation

Anirudh31415926535 commented Jun 19, 2024 • edited Loading

vercel bot commented Jun 19, 2024 • edited Loading

dosubot bot Jun 19, 2024

Choose a reason for hiding this comment

dosubot bot Jun 19, 2024

Choose a reason for hiding this comment

dosubot bot Jun 19, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jacoblee93 commented Jun 21, 2024

Choose a reason for hiding this comment

jacoblee93 Jul 2, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Anirudh31415926535 commented Jul 8, 2024

jacoblee93 commented Jul 9, 2024

jacoblee93 commented Jul 9, 2024

jacoblee93 commented Jul 9, 2024

Anirudh31415926535 commented Jun 19, 2024 •

edited

Loading

vercel bot commented Jun 19, 2024 •

edited

Loading

jacoblee93 Jul 2, 2024 •

edited

Loading