Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

openai[patch]: Set stream_usage to false by default for Azure #5919

Merged
merged 1 commit into from
Jun 27, 2024

Conversation

jacoblee93
Copy link
Collaborator

CC @ccurme

Copy link

vercel bot commented Jun 27, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
langchainjs-api-refs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 27, 2024 4:06pm
langchainjs-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 27, 2024 4:06pm

@dosubot dosubot bot added size:S This PR changes 10-29 lines, ignoring generated files. auto:nit Small modifications/deletions, fixes, deps or improvements to existing code or docs labels Jun 27, 2024
@jacoblee93 jacoblee93 merged commit 40f7351 into main Jun 27, 2024
36 of 37 checks passed
@jacoblee93 jacoblee93 deleted the jacob/openai branch June 27, 2024 16:59
@deranga
Copy link
Contributor

deranga commented Jul 3, 2024

@jacoblee93 it seems that streamUsage is broken in 0.2.8, and its not possible to set streamUsage when instantiating the class. Can't see how its related to the commit attached to this, but couldn't find any other obvious culprits in 0.2.7 or 0.2.8 releases.

The code in the main langchain branch now looks as though it ought to work (default to true without setting it), just doesn't look to be part of 0.2.8. Is that correct?

@jacoblee93
Copy link
Collaborator Author

jacoblee93 commented Jul 3, 2024

Hey @deranga sorry about this - this would be part of @langchain/openai here, which is on 0.2.1:

https://www.npmjs.com/package/@langchain/openai

It's independent of langchain - bumping should hopefully fix. If not let me know!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto:nit Small modifications/deletions, fixes, deps or improvements to existing code or docs size:S This PR changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants