Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

community[patch]: Fix typo in modelName options of BaiduQianfanEmbeddings #5970

Merged
merged 1 commit into from
Jul 19, 2024

Conversation

DOTime
Copy link
Contributor

@DOTime DOTime commented Jul 3, 2024

model name bge-large-en should be bge_large_en like bge_large_zh

at line 188 in the same file: https://aip.baidubce.com/rpc/2.0/ai_custom/v1/wenxinworkshop/embeddings/${this.modelName}?access_token=${this.accessToken}

${this.modelName} directly used in the URL

image
URL for the image:https://cloud.baidu.com/doc/WENXINWORKSHOP/s/mllz05nzk

@dosubot dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Jul 3, 2024
Copy link

vercel bot commented Jul 3, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
langchainjs-api-refs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 3, 2024 9:37am
langchainjs-docs ✅ Ready (Inspect) Visit Preview Jul 3, 2024 9:37am

@dosubot dosubot bot added the auto:nit Small modifications/deletions, fixes, deps or improvements to existing code or docs label Jul 3, 2024
@jacoblee93
Copy link
Collaborator

Thank you!

@jacoblee93
Copy link
Collaborator

This class was actually deprecated in favor of this one:

https://github.com/langchain-ai/langchainjs/blob/main/libs/langchain-baidu-qianfan/src/embeddings.ts

Could you change it there too?

@jacoblee93
Copy link
Collaborator

CC @dl102306

Copy link
Member

@bracesproul bracesproul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for catching this!

@dosubot dosubot bot added the lgtm PRs that are ready to be merged as-is label Jul 7, 2024
@bracesproul bracesproul changed the title chore: Fix typo in modelName options community[patch]: Fix typo in modelName options Jul 7, 2024
@bracesproul bracesproul changed the title community[patch]: Fix typo in modelName options community[patch]: Fix typo in modelName options of BaiduQianfanEmbeddings Jul 7, 2024
Copy link
Member

@bracesproul bracesproul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missed Jacob's comments. Requesting changes until resolved

@dosubot dosubot bot removed the lgtm PRs that are ready to be merged as-is label Jul 7, 2024
@jacoblee93
Copy link
Collaborator

@dl102306 could you verify this is good?

@jacoblee93 jacoblee93 merged commit 57707b0 into langchain-ai:main Jul 19, 2024
37 checks passed
@jacoblee93
Copy link
Collaborator

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto:nit Small modifications/deletions, fixes, deps or improvements to existing code or docs size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants