openai[patch]: Fix integration tests #5998
Merged
+690
−537
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
dosubot
bot
added
size:XXL
![dosubot[bot]](https://avatars.githubusercontent.com/in/324583?s=60&v=4){kind=small}
| @@ -23,6 +25,9 @@ import { | |||
| } from "@azure/identity"; | |||
There was a problem hiding this comment.
Hey team, I've noticed that a new line has been added to save the original value of the 'LANGCHAIN_CALLBACKS_BACKGROUND' environment variable. This is just a heads up for the maintainers to review this change. Let me know if you need further assistance with this.
| @@ -1,3 +1,5 @@ | |||
| /* eslint-disable no-process-env */ | |||
There was a problem hiding this comment.
Hey there! I noticed that the recent change in the code includes a comment disabling the eslint rule for direct usage of process.env. This is flagged for your review to ensure proper handling of environment variables. Keep up the great work!
This was referenced Aug 2, 2024
This was referenced Aug 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tests which relied on callbacks are flaky if
LANGCHAIN_CALLBACKS_BACKGROUNDis set totrue. This is due to those callback funcs not necessarily completing until after the parent fn (in this case a chat model) has resolved. To solve this, I wrapped those tests in atry { ... } finally { ... }and setLANGCHAIN_CALLBACKS_BACKGROUNDto false at the start of the test, and inside thefinallyblock I reset it to the original value.I also updated the Azure test
Test Azure ChatOpenAI with bearer token providerto first check if the required env vars are set. If they are, it runs the test as normal. If not, it marks the test as skipped. Ideally we remove this code once we get our hands on those vars 🙃