Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs[patch],community[minor]: Update AssemblyAI SDK, add user agent, update AssemblyAI URLs #6084

Merged
merged 4 commits into from
Jul 16, 2024
Merged

docs[patch],community[minor]: Update AssemblyAI SDK, add user agent, update AssemblyAI URLs #6084

merged 4 commits into from
Jul 16, 2024

Conversation

Swimburger
Copy link
Contributor

  • Update AssemblyAI SDK to 4.6.0
  • Update URLs to AssemblyAI to new locations and attribute referral from LangChain docs
  • Configure LangChainJS as the user agent for the AssemblyAI SDK which lets us attribute usage to the LangChainJS integration

@dosubot dosubot bot added the size:M This PR changes 30-99 lines, ignoring generated files. label Jul 16, 2024
@vercel Vercel
Copy link

vercel bot commented Jul 16, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
langchainjs-api-refs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 16, 2024 8:59pm
langchainjs-docs ✅ Ready (Inspect) Visit Preview Jul 16, 2024 8:59pm

@dosubot dosubot bot added the auto:documentation Changes to documentation and examples, like .md, .rst, .ipynb files. Changes to the docs/ folder label Jul 16, 2024
bracesproul
bracesproul reviewed Jul 16, 2024
View reviewed changes
Copy link
Member

@bracesproul bracesproul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple nits around import paths, otherwise this looks good

@bracesproul bracesproul changed the title Update AssemblyAI SDK, add user agent, update AssemblyAI URLs docs[patch],community[minor]: Update AssemblyAI SDK, add user agent, update AssemblyAI URLs Jul 16, 2024
bracesproul
bracesproul approved these changes Jul 16, 2024
View reviewed changes
Copy link
Member

@bracesproul bracesproul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm as long as CI passes!

@dosubot dosubot bot added the lgtm PRs that are ready to be merged as-is label Jul 16, 2024
@bracesproul bracesproul merged commit 795ca0b into langchain-ai:main Jul 16, 2024
44 checks passed
@Swimburger Swimburger deleted the niels/update-assemblyai-sdk branch July 17, 2024 05:02
@prathik2401 prathik2401 mentioned this pull request Aug 15, 2024
Merged
@riderx riderx mentioned this pull request Aug 18, 2024
Closed
@sam2177142 sam2177142 mentioned this pull request Aug 19, 2024
Open
@prathik2401 prathik2401 mentioned this pull request Aug 21, 2024
Merged
@riderx riderx mentioned this pull request Aug 21, 2024
Closed
@WesleyR10 WesleyR10 mentioned this pull request Aug 21, 2024
Open
@riderx riderx mentioned this pull request Aug 23, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bracesproul bracesproul bracesproul approved these changes

Assignees
No one assigned
Labels
auto:documentation Changes to documentation and examples, like .md, .rst, .ipynb files. Changes to the docs/ folder lgtm PRs that are ready to be merged as-is size:M This PR changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Swimburger @bracesproul