Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

aws[major]: Added retrievers to aws package #6140

Merged
merged 3 commits into from
Jul 18, 2024
Merged

Conversation

bracesproul
Copy link
Member

@bracesproul bracesproul commented Jul 18, 2024

Ported from community

Copy link

vercel bot commented Jul 18, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
langchainjs-api-refs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 18, 2024 10:24pm
langchainjs-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 18, 2024 10:24pm

@bracesproul bracesproul marked this pull request as ready for review July 18, 2024 21:59
@dosubot dosubot bot added size:XL This PR changes 500-999 lines, ignoring generated files. auto:enhancement A large net-new component, integration, or chain. Use sparingly. The largest features labels Jul 18, 2024
@@ -39,7 +39,9 @@
"author": "LangChain",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey there! 👋 I've reviewed the PR and noticed that it adds new peer dependencies for the project, specifically "@aws-sdk/client-bedrock-agent-runtime" and "@aws-sdk/client-kendra". I've flagged this for your review to ensure it aligns with the project's requirements. Keep up the great work! 🚀

@@ -0,0 +1,30 @@
/* eslint-disable no-process-env */
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey there! I've reviewed the code and it looks like the changes explicitly access and require environment variables via process.env. I've flagged this for your review to ensure the handling of environment variables aligns with best practices.

@@ -0,0 +1,32 @@
/* eslint-disable no-process-env */
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey there! I've reviewed the code and noticed that the added lines explicitly access environment variables via process.env. I've flagged this for your review to ensure proper handling of environment variables. Let me know if you have any questions or need further assistance!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto:enhancement A large net-new component, integration, or chain. Use sparingly. The largest features size:XL This PR changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant