-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
aws[major]: Added retrievers to aws package #6140
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
@@ -39,7 +39,9 @@ | |||
"author": "LangChain", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey there! 👋 I've reviewed the PR and noticed that it adds new peer dependencies for the project, specifically "@aws-sdk/client-bedrock-agent-runtime" and "@aws-sdk/client-kendra". I've flagged this for your review to ensure it aligns with the project's requirements. Keep up the great work! 🚀
@@ -0,0 +1,30 @@ | |||
/* eslint-disable no-process-env */ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey there! I've reviewed the code and it looks like the changes explicitly access and require environment variables via process.env
. I've flagged this for your review to ensure the handling of environment variables aligns with best practices.
@@ -0,0 +1,32 @@ | |||
/* eslint-disable no-process-env */ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey there! I've reviewed the code and noticed that the added lines explicitly access environment variables via process.env
. I've flagged this for your review to ensure proper handling of environment variables. Let me know if you have any questions or need further assistance!
Ported from community