-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
groq[minor]: Implement streaming tool calls #6203
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
…to brace/stream-groq-tools
@@ -35,9 +35,9 @@ | |||
"author": "LangChain", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey there! 👋 I noticed that the dependency changes in the package.json file might impact the project's peer/dev/hard dependencies. I've flagged this for your review as it's important to ensure compatibility and stability. Keep up the great work! 🚀
@@ -391,76 +411,45 @@ export class ChatGroq extends BaseChatModel< | |||
): AsyncGenerator<ChatGenerationChunk> { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey team, I've flagged this PR for your review as it introduces a new external HTTP request using this.completionWithRetry
. This comment is to ensure the change is reviewed and aligned with our project's requirements. Let me know if you need further clarification.
Their API doesn't appear to yield more than one chunk.
This change simply calls the streaming endpoint instead of non-streaming when tools are passed.