Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

groq[minor]: Implement streaming tool calls #6203

Merged
merged 7 commits into from
Jul 25, 2024
Merged

Conversation

bracesproul
Copy link
Member

Their API doesn't appear to yield more than one chunk.
This change simply calls the streaming endpoint instead of non-streaming when tools are passed.

Copy link

vercel bot commented Jul 25, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
langchainjs-api-refs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 25, 2024 9:41pm
langchainjs-docs ✅ Ready (Inspect) Visit Preview Jul 25, 2024 9:41pm

@bracesproul bracesproul marked this pull request as ready for review July 25, 2024 00:51
@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. auto:improvement Medium size change to existing code to handle new use-cases labels Jul 25, 2024
@@ -35,9 +35,9 @@
"author": "LangChain",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey there! 👋 I noticed that the dependency changes in the package.json file might impact the project's peer/dev/hard dependencies. I've flagged this for your review as it's important to ensure compatibility and stability. Keep up the great work! 🚀

@@ -391,76 +411,45 @@ export class ChatGroq extends BaseChatModel<
): AsyncGenerator<ChatGenerationChunk> {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey team, I've flagged this PR for your review as it introduces a new external HTTP request using this.completionWithRetry. This comment is to ensure the change is reviewed and aligned with our project's requirements. Let me know if you need further clarification.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto:improvement Medium size change to existing code to handle new use-cases size:L This PR changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant