Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs[minor]: Simplify example code by getting rid of unnecessary else/if statements #6232

Merged
merged 6 commits into from
Jul 29, 2024

Conversation

kostasx
Copy link
Contributor

@kostasx kostasx commented Jul 27, 2024

Removing unnecessary else/if statements to make the JS code easier to read and comprehend as per the (No-else-return) ESLint rule.

kostasx added 4 commits July 9, 2024 23:35
Just adding a missing period.
Make the code example cleaner and easier to read by removing unnecessary else/if statements.
@dosubot dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Jul 27, 2024
Copy link

vercel bot commented Jul 27, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
langchainjs-api-refs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 27, 2024 0:43am
langchainjs-docs ✅ Ready (Inspect) Visit Preview Jul 27, 2024 0:43am

@dosubot dosubot bot added the auto:nit Small modifications/deletions, fixes, deps or improvements to existing code or docs label Jul 27, 2024
@kostasx kostasx changed the title Simplify code by getting rid of unnecessary else/if statements docs[minor] Simplify code by getting rid of unnecessary else/if statements Jul 27, 2024
@kostasx kostasx changed the title docs[minor] Simplify code by getting rid of unnecessary else/if statements docs[minor]: Simplify code by getting rid of unnecessary else/if statements Jul 27, 2024
@kostasx kostasx changed the title docs[minor]: Simplify code by getting rid of unnecessary else/if statements docs[minor]: Simplify example code by getting rid of unnecessary else/if statements Jul 27, 2024
Copy link
Member

@bracesproul bracesproul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for this!

@dosubot dosubot bot added the lgtm PRs that are ready to be merged as-is label Jul 27, 2024
@vercel vercel bot temporarily deployed to Preview – langchainjs-api-refs July 27, 2024 00:16 Inactive
@vercel vercel bot temporarily deployed to Preview – langchainjs-docs July 27, 2024 00:18 Inactive
@dosubot dosubot bot added size:S This PR changes 10-29 lines, ignoring generated files. and removed size:XS This PR changes 0-9 lines, ignoring generated files. labels Jul 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto:nit Small modifications/deletions, fixes, deps or improvements to existing code or docs lgtm PRs that are ready to be merged as-is size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants