Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(openai): Support audio output #7012

Merged
merged 6 commits into from
Oct 17, 2024
Merged

Conversation

bracesproul
Copy link
Member

TODO:

  • run standard int tests
  • test azure
  • add docs

Copy link

vercel bot commented Oct 17, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
langchainjs-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 17, 2024 9:08pm
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
langchainjs-api-refs ⬜️ Ignored (Inspect) Oct 17, 2024 9:08pm

Copy link
Collaborator

@jacoblee93 jacoblee93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should add this to CallOptions and add a test for .bind

@@ -1190,6 +1207,8 @@ export class ChatOpenAI<
seed: options?.seed,
...streamOptionsConfig,
parallel_tool_calls: options?.parallel_tool_calls,
audio: this.audio,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

May be slightly safer to add these fields only if they are present - not sure how Azure or other model proxies will react to adding audio: undefined

@bracesproul bracesproul marked this pull request as ready for review October 17, 2024 20:49
@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. auto:documentation Changes to documentation and examples, like .md, .rst, .ipynb files. Changes to the docs/ folder auto:enhancement A large net-new component, integration, or chain. Use sparingly. The largest features labels Oct 17, 2024
@bracesproul bracesproul merged commit 2a08a03 into main Oct 17, 2024
35 checks passed
@bracesproul bracesproul deleted the brace/oai-support-audio-output branch October 17, 2024 21:23
bracesproul added a commit that referenced this pull request Oct 17, 2024
CarterMorris pushed a commit to CarterMorris/langchainjs that referenced this pull request Nov 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto:documentation Changes to documentation and examples, like .md, .rst, .ipynb files. Changes to the docs/ folder auto:enhancement A large net-new component, integration, or chain. Use sparingly. The largest features size:L This PR changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants