feat(community): Add property extraction for Nodes and Relationships in LLMGraphTransformer #7256
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
the
size:L
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
dosubot
bot
added
the
auto:improvement
|
Thank you! Tagging in @easwee or @tomasonjo to have a look |
tomasonjo
reviewed
Nov 26, 2024
| @@ -5,8 +5,8 @@ | |||
| "rootDir": "./src", | |||
| "target": "ES2021", | |||
| "lib": ["ES2021", "ES2022.Object", "DOM"], | |||
| "module": "ES2020", | |||
| "moduleResolution": "nodenext", | |||
| "module": "NodeNext", | |||
There was a problem hiding this comment.
Probably don't want to change tsconfig file
There was a problem hiding this comment.
Indeed! I was using Typescript 5.2 locally and faced an issue with module being ES2020. Reverted.
There was a problem hiding this comment.
Yeah, you have to use TS 5.1 to build locally. It's bad and we need to fix it at some point.
There was a problem hiding this comment.
Yes, that would be good. In any case, I've reverted that particular change. @jacoblee93 do you see any other areas for feedback?
jacoblee93
changed the title
|
Thank you both! |
syntaxsec
pushed a commit
to aks-456/langchainjs
that referenced
this pull request
Dec 13, 2024
…in LLMGraphTransformer (langchain-ai#7256) Co-authored-by: Jacob Lee <jacoblee93@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for extracting Node and Relationship properties on
LLMGraphTransformer, similar to the Python version. A key distinction is that arbitrary property extraction is not supported. The caller needs to specify the property keys in advance.This is my first contribution here, so please let me know if I've missed anything, or if there is any feedback. Thank you!