Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(community): Fix interface of chat deployment IBM and add test for this case #7666

Merged
merged 7 commits into from
Feb 11, 2025

Conversation

FilipZmijewski
Copy link
Contributor

Fixes # (issue)

* Rename auth method in docs

* Rename auth method in docs

* Add deployment chat to chat class

* Upadate Watsonx sdk

* Rework interfaces in llms as well

* Bump watsonx-ai sdk version

* Remove unused code

* Add fake auth
@dosubot dosubot bot added the size:M This PR changes 30-99 lines, ignoring generated files. label Feb 7, 2025
Copy link

vercel bot commented Feb 7, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
langchainjs-docs ✅ Ready (Inspect) Visit Preview Feb 10, 2025 9:14am
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
langchainjs-api-refs ⬜️ Ignored (Inspect) Feb 10, 2025 9:14am

@FilipZmijewski FilipZmijewski changed the title fix: Fix interface of chat deployment and add test for this case fix: Fix interface of chat deployment IBM and add test for this case Feb 7, 2025
@@ -254,6 +254,7 @@
"@ibm-cloud/watsonx-ai": "*",
"@lancedb/lancedb": "^0.12.0",
"@langchain/core": ">=0.2.21 <0.4.0",
"@langchain/langgraph": "*",
Copy link
Collaborator

@jacoblee93 jacoblee93 Feb 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add to dev deps if at all but would prefer to avoid this as it causes issues with build pulling in old core versions

You can add a file to examples/, which does have a @langchain/langgraph dep - not a great system but it'll at least catch type errors on repo build

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I reworked it with a 'dummy' function, does the same and no import needed. Just pushed the changes Please, have a look

@dosubot dosubot bot added size:S This PR changes 10-29 lines, ignoring generated files. and removed size:M This PR changes 30-99 lines, ignoring generated files. labels Feb 10, 2025
Copy link
Collaborator

@jacoblee93 jacoblee93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@dosubot dosubot bot added the lgtm PRs that are ready to be merged as-is label Feb 11, 2025
@jacoblee93 jacoblee93 changed the title fix: Fix interface of chat deployment IBM and add test for this case fix(community): Fix interface of chat deployment IBM and add test for this case Feb 11, 2025
@jacoblee93 jacoblee93 merged commit 5449925 into langchain-ai:main Feb 11, 2025
31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm PRs that are ready to be merged as-is size:S This PR changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants