feat(cli): add debugger host CLI flag to specify default base URL #900
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vbarda
reviewed
Jul 1, 2024
vbarda
reviewed
Jul 1, 2024
| @@ -117,11 +105,36 @@ def check_capabilities(runner) -> DockerCapabilities: | |||
| ) | |||
|
|
|||
|
|
|||
| def debugger_compose(*, port: Optional[int] = None, host: Optional[str] = None) -> str: | |||
| if port is None: | |||
There was a problem hiding this comment.
IMO this is not very intuitive. could we do this check on host instead?
- cli option for host: no default in
click - cli option for port: default to
DEFAULT_PORTinclick
and below add environment only if host != localhost?
There was a problem hiding this comment.
This is not really for changing the host of the debugger image, rather to change the default URL used by the debugger to access the LangGraph API.
Renamed the CLI flag to closely match the intent.
There was a problem hiding this comment.
ah, that makes sense, thanks for clarifying!
vbarda
approved these changes
Jul 8, 2024
| @@ -117,11 +105,36 @@ def check_capabilities(runner) -> DockerCapabilities: | |||
| ) | |||
|
|
|||
|
|
|||
| def debugger_compose(*, port: Optional[int] = None, host: Optional[str] = None) -> str: | |||
| if port is None: | |||
There was a problem hiding this comment.
ah, that makes sense, thanks for clarifying!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.