Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

langgraph: add tool error handling #910

Merged
merged 2 commits into from
Jul 3, 2024
Merged

langgraph: add tool error handling #910

merged 2 commits into from
Jul 3, 2024

Conversation

vbarda
Copy link
Collaborator

@vbarda vbarda commented Jul 3, 2024

No description provided.

Copy link
Contributor

@hinthornw hinthornw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ya this is what I had in mind. I'd also be a fan of letting the user pass a callable in:

handle_tool_errors = Optional[Union[
bool,
Callable[[BaseException, ToolCall, Optional[BaseTool]], str]
]] = None

But perhaps yagni

@vbarda
Copy link
Collaborator Author

vbarda commented Jul 3, 2024

Ya this is what I had in mind. I'd also be a fan of letting the user pass a callable in:

handle_tool_errors = Optional[Union[
bool,
Callable[[BaseException, ToolCall, Optional[BaseTool]], str]
]] = None

But perhaps yagni

Is there a use case where this would be immediately useful for you? Otherwise I'd rather keep it simple for the time being, and add later if we need to

@vbarda vbarda merged commit cd3a1cb into main Jul 3, 2024
27 checks passed
@vbarda vbarda deleted the vb/add-tool-handling branch July 3, 2024 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants