Skip to content

Commit

Permalink
Build 3.13 wheels for all platforms except Windows.
Browse files Browse the repository at this point in the history
Building on Windows seems to fail with a linking error, the same one as here: PyO3/maturin-action#292
  • Loading branch information
obi1kenobi committed Nov 27, 2024
1 parent 5f16a92 commit ae42499
Showing 1 changed file with 7 additions and 4 deletions.
11 changes: 7 additions & 4 deletions .github/workflows/build_langsmith_pyo3_wheels.yml
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,10 @@ permissions:

env:
RUST_VERSION: '1.82' # Be careful, "stable" gets you "whatever GitHub ships", which is quite old.
SUPPORTED_PYTHON_VERSIONS: 'python3.8 python3.9 python3.10 python3.11 python3.12 python3.13'
# Building wheels for Python 3.13 on Windows is broken at the moment with a linking error,
# so we build 3.13 wheels for other platforms explicitly instead of adding 3.13 here.
# https://github.com/PyO3/maturin-action/issues/292
SUPPORTED_PYTHON_VERSIONS: 'python3.8 python3.9 python3.10 python3.11 python3.12'
WORKING_DIRECTORY: rust/crates/langsmith-pyo3

jobs:
Expand All @@ -59,7 +62,7 @@ jobs:
working-directory: ${{ env.WORKING_DIRECTORY }}
rust-toolchain: ${{ env.RUST_VERSION }}
target: ${{ matrix.platform.target }}
args: '--release --out dist --interpreter ${{ env.SUPPORTED_PYTHON_VERSIONS }}'
args: '--release --out dist --interpreter ${{ env.SUPPORTED_PYTHON_VERSIONS }} python3.13'
sccache: 'true'
manylinux: '2_28' # The default is 'auto' AKA '2014', which is too old for us.
# Workaround for missing `pip` in manylinux_2_28:
Expand Down Expand Up @@ -92,7 +95,7 @@ jobs:
working-directory: ${{ env.WORKING_DIRECTORY }}
rust-toolchain: ${{ env.RUST_VERSION }}
target: ${{ matrix.platform.target }}
args: '--release --out dist --interpreter ${{ env.SUPPORTED_PYTHON_VERSIONS }}'
args: '--release --out dist --interpreter ${{ env.SUPPORTED_PYTHON_VERSIONS }} python3.13'
sccache: 'true'
manylinux: musllinux_1_2
- name: Upload wheels
Expand Down Expand Up @@ -150,7 +153,7 @@ jobs:
working-directory: ${{ env.WORKING_DIRECTORY }}
rust-toolchain: ${{ env.RUST_VERSION }}
target: ${{ matrix.platform.target }}
args: '--release --out dist --interpreter ${{ env.SUPPORTED_PYTHON_VERSIONS }}'
args: '--release --out dist --interpreter ${{ env.SUPPORTED_PYTHON_VERSIONS }} python3.13'
sccache: 'true'
- name: Upload wheels
uses: actions/upload-artifact@v4
Expand Down

0 comments on commit ae42499

Please sign in to comment.