Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update default url #94

Merged
merged 1 commit into from
Jul 15, 2023
Merged

Update default url #94

merged 1 commit into from
Jul 15, 2023

Conversation

hinthornw
Copy link
Collaborator

@hinthornw hinthornw commented Jul 15, 2023

Currently presumes localhost if not specified.
Suggested change would be to assume prod https://api.smith.langchain.com if an api key is specified, otherwise fall back to localhost.

Would eliminate 1 strictly required env var

@agola11
Copy link
Contributor

agola11 commented Jul 15, 2023

Won't this actually make it hard to test dev?

@agola11
Copy link
Contributor

agola11 commented Jul 15, 2023

nvm I see you can still explicitly set it. I would just sanity check that!

@hinthornw hinthornw merged commit 7f6a513 into main Jul 15, 2023
@hinthornw hinthornw deleted the wfh/infer_remote branch July 15, 2023 20:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants