Get rid of lombok for langchain4j-spring-boot-starter and langchain4j-open-ai-spring-boot-starter #49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qing-wq
pushed a commit
to qing-wq/langchain4j-spring
that referenced
this pull request
Nov 20, 2024
…-open-ai-spring-boot-starter (langchain4j#49) ## Issue Langchain4j project issue: langchain4j/langchain4j#1636 ## Change Get rid of lombok from 2 modules: `langchain4j-spring-boot-starter` and `langchain4j-open-ai-spring-boot-starter`. I'll use java `record` for class annotated with `@ConfigurationProperties`. I don't have any credentials/API keys to refactor then test others modules. ## General checklist - [X] There are no breaking changes - [ ] I have added unit and integration tests for my change - [X] I have manually run all the unit and integration tests in the module I have added/changed, and they are all green - [ ] I have manually run all the unit and integration tests in the [core](https://github.com/langchain4j/langchain4j/tree/main/langchain4j-core) and [main](https://github.com/langchain4j/langchain4j/tree/main/langchain4j) modules, and they are all green - [ ] I have added/updated the [documentation](https://github.com/langchain4j/langchain4j/tree/main/docs/docs) - [ ] I have added an example in the [examples repo](https://github.com/langchain4j/langchain4j-examples) (only for "big" features) - [ ] I have added/updated [Spring Boot starter(s)](https://github.com/langchain4j/langchain4j-spring) (if applicable)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Langchain4j project issue: langchain4j/langchain4j#1636
Change
Get rid of lombok from 2 modules:
langchain4j-spring-boot-starterandlangchain4j-open-ai-spring-boot-starter.I'll use java
recordfor class annotated with@ConfigurationProperties.I don't have any credentials/API keys to refactor then test others modules.
General checklist
Checklist for adding new maven module
pom.xmlandlangchain4j-bom/pom.xmlChecklist for adding new embedding store integration
{NameOfIntegration}EmbeddingStoreITthat extends from eitherEmbeddingStoreITorEmbeddingStoreWithFilteringIT{NameOfIntegration}EmbeddingStoreRemovalITthat extends fromEmbeddingStoreWithRemovalITChecklist for changing existing embedding store integration
{NameOfIntegration}EmbeddingStoreworks correctly with the data persisted using the latest released version of LangChain4j