Fix #2133 Spring boot starter breaks configuration classes #79
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@qing-wq thanks a lot! |
qing-wq
changed the title
|
@langchain4j certainly! I have completed the unit test |
langchain4j
approved these changes
Nov 21, 2024
langchain4j
pushed a commit
that referenced
this pull request
Nov 21, 2024
Fixes langchain4j/langchain4j#2133 The problem is `beanfactory.getBeanswithanNotation()`. It creates an instance of the Bean in advance. https://github.com/langchain4j/langchain4j-spring/blob/405fddafbcf8c3463c7211dc82b7c5887f9531c6/langchain4j-spring-boot-starter/src/main/java/dev/langchain4j/service/spring/AiServiceScannerProcessor.java#L49 (cherry picked from commit 15f4c95)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes langchain4j/langchain4j#2133
The problem is
beanfactory.getBeanswithanNotation(). It creates an instance of the Bean in advance.langchain4j-spring/langchain4j-spring-boot-starter/src/main/java/dev/langchain4j/service/spring/AiServiceScannerProcessor.java
Line 49 in 405fdda