Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Ollama model component parameter #2935

Merged
merged 3 commits into from
Jul 24, 2024
Merged

fix: Ollama model component parameter #2935

merged 3 commits into from
Jul 24, 2024

Conversation

saikolasani
Copy link
Contributor

Closes #2885

@dosubot dosubot bot added size:XS This PR changes 0-9 lines, ignoring generated files. bug Something isn't working python Pull requests that update Python code labels Jul 24, 2024
@saikolasani saikolasani self-assigned this Jul 24, 2024
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Jul 24, 2024
@saikolasani saikolasani enabled auto-merge (squash) July 24, 2024 22:05
Copy link

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-2935.dmtpw4p5recq1.amplifyapp.com

Copy link
Contributor

Pull Request Validation Report

This comment is automatically generated by Conventional PR

Whitelist Report

Whitelist Active Result
Pull request is a draft and should be ignored
Pull request is made by a whitelisted user and should be ignored
Pull request is submitted by a bot and should be ignored
Pull request is submitted by administrators and should be ignored

Result

Pull request does not satisfy any enabled whitelist criteria. Pull request will be validated.

Validation Report

Validation Active Result
All commits in this pull request has valid messages
Pull request does not introduce too many changes
Pull request has a valid title
Pull request has mentioned issues
Pull request has valid branch name
Pull request should have a non-empty body

Result

Pull request satisfies all enabled pull request rules.

Last Modified at 24 Jul 24 22:10 UTC

@github-actions github-actions bot added bug Something isn't working and removed bug Something isn't working labels Jul 24, 2024
@saikolasani saikolasani merged commit 23b54a6 into main Jul 24, 2024
50 checks passed
@saikolasani saikolasani deleted the sai/ollama-fix branch July 24, 2024 23:51
nicoloboschi pushed a commit to datastax/ragstack-ai-langflow that referenced this pull request Jul 30, 2024
change params from model to model_name"

Co-authored-by: Sai Kolasani <sai.kolasani@datastax.com>
(cherry picked from commit 23b54a6)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working lgtm This PR has been approved by a maintainer python Pull requests that update Python code size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ollama component cannot get models from Ollama server
2 participants