Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: prevent possible race condition on upload flows/folders #4114

Merged
merged 5 commits into from
Oct 11, 2024
Merged

fix: prevent possible race condition on upload flows/folders #4114

merged 5 commits into from
Oct 11, 2024

Commits on Oct 11, 2024

  1. ✨ (create-file-upload.ts): improve file upload functionality by addin… 

    …g cleanup logic and handling edge cases for resolving file selection
    @Cristhianzl
    Cristhianzl committed Oct 11, 2024
    Configuration menu
    Copy the full SHA
    f4e4008 View commit details
    Browse the repository at this point in the history

  2. 🐛 (create-file-upload.ts): fix removing input element from the DOM by… 

    … checking if it is contained in the document body before removal

💡 (create-file-upload.ts): add a comment to clarify the purpose of the setTimeout function for a fallback timeout of 1 minute
    @Cristhianzl
    Cristhianzl committed Oct 11, 2024
    Configuration menu
    Copy the full SHA
    15138d9 View commit details
    Browse the repository at this point in the history

  3. ✨ (create-file-upload.ts): change createFileUpload function to be asy… 

    …nchronous to support Promise return type for better handling of file upload operations
    @Cristhianzl
    Cristhianzl committed Oct 11, 2024
    Configuration menu
    Copy the full SHA
    3ad4334 View commit details
    Browse the repository at this point in the history

  4. 📝 (create-file-upload.ts): improve error handling when removing input… 

    … element from the DOM

📝 (create-file-upload.ts): remove unnecessary comment about timeout value in the code
    @Cristhianzl
    Cristhianzl committed Oct 11, 2024
    Configuration menu
    Copy the full SHA
    c0b2c11 View commit details
    Browse the repository at this point in the history

  5. Merge branch 'main' into cz/4070

    @Cristhianzl
    Cristhianzl authored Oct 11, 2024
    Configuration menu
    Copy the full SHA
    b6dcf82 View commit details
    Browse the repository at this point in the history