fix: Update duckduckgo-search to 6.3.4 and improve tests #4504
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
….3.4 🔧 (duckduckgo.spec.ts): remove test.skip from the test case to enable the test for duckduckgo search component 💡 (duckduckgo.spec.ts): refactor test case to improve readability and remove unnecessary code blocks
dosubot
bot
added
the
size:S
italojohnny
approved these changes
Nov 11, 2024
ogabrielluiz
approved these changes
Nov 11, 2024
edwinjosechittilappilly
pushed a commit
that referenced
this pull request
Nov 11, 2024
⬆️ (pyproject.toml): update duckduckgo-search dependency to version 6.3.4 🔧 (duckduckgo.spec.ts): remove test.skip from the test case to enable the test for duckduckgo search component 💡 (duckduckgo.spec.ts): refactor test case to improve readability and remove unnecessary code blocks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes updates to dependencies and improvements to the DuckDuckGo search component test. The most important changes include updating the
duckduckgo-searchdependency version and modifying the test for the DuckDuckGo search component to remove the skip flag and improve the test logic.Dependency updates:
pyproject.toml: Updatedduckduckgo-searchdependency version from6.3.0to6.3.4.Test improvements:
src/frontend/tests/extended/integrations/duckduckgo.spec.ts: Removed the.skipflag from the test for the DuckDuckGo search component, enabling the test to run.src/frontend/tests/extended/integrations/duckduckgo.spec.ts: Modified the test logic to add additional wait times and remove unnecessary rate limit checks, ensuring more reliable test execution.….3.4