Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: disable browser autocomplete on popover input fields #4573

Merged
merged 9 commits into from
Nov 22, 2024

Conversation

Cristhianzl
Copy link
Member

This pull request includes changes to the src/frontend/src/components/inputComponent directory to enhance the user experience by disabling the browser's autocomplete feature on input fields.

Key changes include:

@Cristhianzl Cristhianzl self-assigned this Nov 13, 2024
@dosubot dosubot bot added size:XS This PR changes 0-9 lines, ignoring generated files. enhancement New feature or request javascript Pull requests that update Javascript code labels Nov 13, 2024
@github-actions github-actions bot added enhancement New feature or request and removed enhancement New feature or request labels Nov 13, 2024
anovazzi1
anovazzi1 previously approved these changes Nov 13, 2024
Copy link
Contributor

@anovazzi1 anovazzi1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Nov 13, 2024
@ogabrielluiz ogabrielluiz removed the lgtm This PR has been approved by a maintainer label Nov 13, 2024
…nents in popover and popoverObject to disable browser auto-fill feature
@anovazzi1 anovazzi1 force-pushed the cz/remove-auto-complete branch from f25344d to 7b3d6f0 Compare November 13, 2024 20:46
Copy link
Contributor

@anovazzi1 anovazzi1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Nov 18, 2024
…input field to disable browser autocomplete feature
…e to the search input field to disable browser autocomplete feature
…mponents to enable browser autocomplete feature

📝 (ui/input): Remove autoComplete="off" attribute from input element to enable browser autocomplete feature
📝 (extraSidebarComponent): Remove autoComplete="off" attribute from input element to enable browser autocomplete feature
📝 (flowSidebarComponent): Remove autoComplete="off" attribute from Input component to enable browser autocomplete feature
@Cristhianzl Cristhianzl enabled auto-merge (squash) November 19, 2024 17:03
@Cristhianzl Cristhianzl disabled auto-merge November 19, 2024 18:33
Copy link
Contributor

@anovazzi1 anovazzi1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@anovazzi1 anovazzi1 enabled auto-merge (squash) November 22, 2024 19:55
@anovazzi1 anovazzi1 merged commit 0a42341 into main Nov 22, 2024
18 checks passed
@anovazzi1 anovazzi1 deleted the cz/remove-auto-complete branch November 22, 2024 20:13
diogocabral pushed a commit to headlinevc/langflow that referenced this pull request Nov 26, 2024
…ai#4573)

* ✨ (inputComponent): add 'autoComplete="off"' attribute to input components in popover and popoverObject to disable browser auto-fill feature

* ✨ (dropdownComponent/index.tsx): add autoComplete="off" attribute to input field to disable browser autocomplete feature

* ✨ (flowSidebarComponent/index.tsx): add 'autoComplete="off"' attribute to the search input field to disable browser autocomplete feature

* 📝 (inputComponent): Remove autoComplete="off" attribute from Input components to enable browser autocomplete feature
📝 (ui/input): Remove autoComplete="off" attribute from input element to enable browser autocomplete feature
📝 (extraSidebarComponent): Remove autoComplete="off" attribute from input element to enable browser autocomplete feature
📝 (flowSidebarComponent): Remove autoComplete="off" attribute from Input component to enable browser autocomplete feature

---------

Co-authored-by: anovazzi1 <otavio2204@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request javascript Pull requests that update Javascript code lgtm This PR has been approved by a maintainer size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants