-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: disable browser autocomplete on popover input fields #4573
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
size:XS
This PR changes 0-9 lines, ignoring generated files.
enhancement
New feature or request
javascript
Pull requests that update Javascript code
labels
Nov 13, 2024
github-actions
bot
added
enhancement
New feature or request
and removed
enhancement
New feature or request
labels
Nov 13, 2024
anovazzi1
previously approved these changes
Nov 13, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
…nents in popover and popoverObject to disable browser auto-fill feature
anovazzi1
force-pushed
the
cz/remove-auto-complete
branch
from
November 13, 2024 20:46
f25344d
to
7b3d6f0
Compare
anovazzi1
approved these changes
Nov 18, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
…input field to disable browser autocomplete feature
…e to the search input field to disable browser autocomplete feature
…mponents to enable browser autocomplete feature 📝 (ui/input): Remove autoComplete="off" attribute from input element to enable browser autocomplete feature 📝 (extraSidebarComponent): Remove autoComplete="off" attribute from input element to enable browser autocomplete feature 📝 (flowSidebarComponent): Remove autoComplete="off" attribute from Input component to enable browser autocomplete feature
anovazzi1
approved these changes
Nov 20, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
diogocabral
pushed a commit
to headlinevc/langflow
that referenced
this pull request
Nov 26, 2024
…ai#4573) * ✨ (inputComponent): add 'autoComplete="off"' attribute to input components in popover and popoverObject to disable browser auto-fill feature * ✨ (dropdownComponent/index.tsx): add autoComplete="off" attribute to input field to disable browser autocomplete feature * ✨ (flowSidebarComponent/index.tsx): add 'autoComplete="off"' attribute to the search input field to disable browser autocomplete feature * 📝 (inputComponent): Remove autoComplete="off" attribute from Input components to enable browser autocomplete feature 📝 (ui/input): Remove autoComplete="off" attribute from input element to enable browser autocomplete feature 📝 (extraSidebarComponent): Remove autoComplete="off" attribute from input element to enable browser autocomplete feature 📝 (flowSidebarComponent): Remove autoComplete="off" attribute from Input component to enable browser autocomplete feature --------- Co-authored-by: anovazzi1 <otavio2204@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
enhancement
New feature or request
javascript
Pull requests that update Javascript code
lgtm
This PR has been approved by a maintainer
size:XS
This PR changes 0-9 lines, ignoring generated files.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes changes to the
src/frontend/src/components/inputComponent
directory to enhance the user experience by disabling the browser's autocomplete feature on input fields.Key changes include:
src/frontend/src/components/inputComponent/components/popover/index.tsx
: AddedautoComplete="off"
to the input field to prevent browser autocomplete.src/frontend/src/components/inputComponent/components/popoverObject/index.tsx
: AddedautoComplete="off"
to the input field to prevent browser autocomplete.src/frontend/src/components/inputComponent/index.tsx
: AddedautoComplete="off"
to the input field to prevent browser autocomplete.