Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Use AsyncSession in delete_vertex_builds #4653

Merged
merged 2 commits into from
Nov 17, 2024
Merged

fix: Use AsyncSession in delete_vertex_builds #4653

merged 2 commits into from
Nov 17, 2024

Conversation

cbornet
Copy link
Collaborator

@cbornet cbornet commented Nov 16, 2024

Use AsyncSession in delete_vertex_builds

@dosubot dosubot bot added the size:M This PR changes 30-99 lines, ignoring generated files. label Nov 16, 2024
@cbornet cbornet requested a review from ogabrielluiz November 16, 2024 20:47
@dosubot dosubot bot added the bug Something isn't working label Nov 16, 2024
@github-actions github-actions bot added bug Something isn't working and removed bug Something isn't working labels Nov 16, 2024
@cbornet cbornet force-pushed the async-session-delete-vertex-builds branch from c162366 to c9328d0 Compare November 16, 2024 21:52
@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Nov 16, 2024 •
edited
Loading

CodSpeed Performance Report

Merging #4653 will improve performances by 91.01%

Comparing cbornet:async-session-delete-vertex-builds (bb5b22d) with main (da01f5c)

Summary

⚡ 3 improvements
✅ 12 untouched benchmarks

Benchmarks breakdown

Benchmark main cbornet:async-session-delete-vertex-builds Change
⚡ test_successful_run_with_input_type_text 296.7 ms 217.8 ms +36.2%
⚡ test_successful_run_with_output_type_any 271.5 ms 142.1 ms +91.01%
⚡ test_successful_run_with_output_type_debug 218.2 ms 140 ms +55.89%

@cbornet cbornet force-pushed the async-session-delete-vertex-builds branch from c9328d0 to 49c7429 Compare November 16, 2024 22:18
ogabrielluiz
ogabrielluiz approved these changes Nov 17, 2024
View reviewed changes
Copy link
Contributor

@ogabrielluiz ogabrielluiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Nov 17, 2024
@cbornet cbornet enabled auto-merge (squash) November 17, 2024 11:36
@cbornet cbornet merged commit a7aa3ab into langflow-ai:main Nov 17, 2024
20 checks passed
@cbornet cbornet deleted the async-session-delete-vertex-builds branch November 19, 2024 13:26
diogocabral pushed a commit to headlinevc/langflow that referenced this pull request Nov 26, 2024
@cbornet @diogocabral
fix: Use AsyncSession in delete_vertex_builds (langflow-ai#4653)
967e929 
Use AsyncSession in delete_vertex_builds
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ogabrielluiz ogabrielluiz ogabrielluiz approved these changes

Assignees
No one assigned
Labels
bug Something isn't working lgtm This PR has been approved by a maintainer size:M This PR changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cbornet @ogabrielluiz