refactor: Replace InputComponent with Select dropdown #4719
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e toolbar based on scale and tool mode to enhance user experience
…eModal to use a dropdown select component for better user experience and consistency.
… for node toolbar based on scale and tool mode to enhance user experience" This reverts commit 322ba35.
dosubot
bot
added
the
size:M
…er for testing purposes 🔧 (globalVariables.spec.ts, userSettings.spec.ts): Update test scripts to interact with the SelectTrigger using data-testid attribute for consistency and improved testing accuracy
…OnBoard function to improve code readability and maintainability
mieslep
pushed a commit
to mieslep/langflow
that referenced
this pull request
Nov 22, 2024
* 🔧 (nodeToolbarComponent/index.tsx): improve positioning logic for node toolbar based on scale and tool mode to enhance user experience * ✨ (GlobalVariableModal.tsx): Refactor type selection in GlobalVariableModal to use a dropdown select component for better user experience and consistency. * Revert "🔧 (nodeToolbarComponent/index.tsx): improve positioning logic for node toolbar based on scale and tool mode to enhance user experience" This reverts commit 322ba35. * ✨ (GlobalVariableModal.tsx): Add data-testid attribute to SelectTrigger for testing purposes 🔧 (globalVariables.spec.ts, userSettings.spec.ts): Update test scripts to interact with the SelectTrigger using data-testid attribute for consistency and improved testing accuracy * 📝 (userSettings.spec.ts): remove commented out code for focusElementsOnBoard function to improve code readability and maintainability
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes several changes to the frontend components in the
src/frontend/srcdirectory. The main changes involve replacing theInputComponentwith a newSelectcomponent in theGlobalVariableModal.Changes to
GlobalVariableModal:src/frontend/src/components/GlobalVariableModal/GlobalVariableModal.tsx: ImportedSelect,SelectContent,SelectItem,SelectTrigger, andSelectValuefrom../ui/select.src/frontend/src/components/GlobalVariableModal/GlobalVariableModal.tsx: Replaced theInputComponentwith aSelectcomponent for selecting the type of the variable.