Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix overflow for lists in markdown render #4720

Merged
merged 2 commits into from
Nov 19, 2024
Merged

Conversation

anovazzi1
Copy link
Contributor

This pull request adds support for ordered and unordered lists in the ContentDisplay and ChatMessage components. Previously, lists were not properly displayed and could cause overflow. With this change, lists are now rendered correctly and have a maximum width to prevent overflow.

…nd ChatMessage components to prevent overflow
@dosubot dosubot bot added the size:S This PR changes 10-29 lines, ignoring generated files. label Nov 19, 2024
@dosubot dosubot bot added the bug Something isn't working label Nov 19, 2024
@github-actions github-actions bot added bug Something isn't working and removed bug Something isn't working labels Nov 19, 2024
Copy link
Member

@Cristhianzl Cristhianzl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Nov 19, 2024
@anovazzi1 anovazzi1 enabled auto-merge (squash) November 19, 2024 21:13
@anovazzi1 anovazzi1 merged commit 39cec36 into main Nov 19, 2024
24 of 25 checks passed
@anovazzi1 anovazzi1 deleted the fixOverflowMarkdown branch November 19, 2024 21:28
mieslep pushed a commit to mieslep/langflow that referenced this pull request Nov 22, 2024
* feat: Add support for ordered and unordered lists in ContentDisplay and ChatMessage components to prevent overflow
diogocabral pushed a commit to headlinevc/langflow that referenced this pull request Nov 26, 2024
* feat: Add support for ordered and unordered lists in ContentDisplay and ChatMessage components to prevent overflow
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working lgtm This PR has been approved by a maintainer size:S This PR changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants