Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Creating BaseFileComponent, integrating with API Request "to file" feature #4731

Merged
merged 33 commits into from
Nov 26, 2024

Conversation

mieslep
Copy link
Contributor

@mieslep mieslep commented Nov 20, 2024

Requires #4677

The idea of this is to consolidate file handling (including zip file and directories) into the base component, allowing child classes to focus on the particulars of processing a list of files.

@dosubot dosubot bot added size:XL This PR changes 500-999 lines, ignoring generated files. enhancement New feature or request labels Nov 20, 2024
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Nov 26, 2024
@dosubot dosubot bot added size:XXL This PR changes 1000+ lines, ignoring generated files. and removed size:XL This PR changes 500-999 lines, ignoring generated files. labels Nov 26, 2024
@erichare erichare merged commit c6f27b5 into langflow-ai:main Nov 26, 2024
29 checks passed
Copy link

codspeed-hq bot commented Nov 26, 2024

CodSpeed Performance Report

Merging #4731 will degrade performances by 13.41%

Comparing mieslep:phil/file-alt-input (ce18476) with main (654b443)

Summary

⚡ 2 improvements
❌ 1 regressions
✅ 12 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark main mieslep:phil/file-alt-input Change
test_successful_run_with_input_type_text 230.3 ms 266 ms -13.41%
test_successful_run_with_output_type_any 5,049.6 ms 313.2 ms ×16
test_successful_run_with_output_type_debug 321.6 ms 230.4 ms +39.63%

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request lgtm This PR has been approved by a maintainer size:XXL This PR changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants