fix: update "update components" design, implemented update all components functionality, refactor get types #4739
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lucaseduoli
requested review from
mfortman11,
deon-sanchez,
anovazzi1 and
Cristhianzl
dosubot
bot
added
size:L
anovazzi1
requested changes
Nov 20, 2024
There was a problem hiding this comment.
found a bug related to the update all, it does not disappear after update a component directly on it, instead of update using the update all option:
before fix this bug I would suggest to separate this pr in two different prs, one for the new alert design and other for the types refactor and update all in the bottom. IMO this pr is too big (and risk) to be addressed for the next release.
the new alert style is really awesome, great work.
|
Modularized PR into three |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes multiple changes to the
src/frontend/src/CustomNodes/GenericNodecomponents and related files to improve the handling of outdated nodes and streamline the codebase. The most important changes include modifying theNodeStatusandGenericNodecomponents, adding a new hook for updating all nodes, and updating the flow and type management logic.Improvements to
NodeStatusandGenericNodecomponents:src/frontend/src/CustomNodes/GenericNode/components/NodeStatus/index.tsx: Removed unused propertieshandleUpdateCodeandloadingUpdate, and added logic to update the class based onisOutdatedandisUserEditedproperties. [1] [2] [3] [4] [5]src/frontend/src/CustomNodes/GenericNode/index.tsx: Added a warning banner for outdated nodes and removed the old update button logic fromNodeStatus. [1] [2] [3] [4] [5]New hook for updating all nodes:
src/frontend/src/CustomNodes/hooks/use-update-all-nodes.tsx: Introduced a new hookuseUpdateAllNodesto handle updating multiple nodes at once, leveragingcloneDeepfromlodashanduseCallbackfor performance.Flow and type management updates:
src/frontend/src/controllers/API/queries/flows/use-get-types.ts: Added a new query functionuseGetTypesto fetch and manage component types, replacing the oldgetTypesmethod.src/frontend/src/pages/AppInitPage/index.tsx: Updated the initialization logic to fetch types before other data, ensuring types are loaded before proceeding. [1] [2]Additional changes:
src/frontend/src/components/ui/button.tsx: Added a newwarningvariant to the button component for consistent styling of warning messages.src/frontend/src/components/appHeaderComponent/components/FlowMenu/index.tsx: Replaced the oldgetTypesmethod with the newuseGetTypesquery.