Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: ensure unique flow names when assigning to superuser and avoid adding starter projects #4751

Merged
merged 5 commits into from
Nov 21, 2024
Merged

fix: ensure unique flow names when assigning to superuser and avoid adding starter projects #4751

merged 5 commits into from
Nov 21, 2024

Conversation

italojohnny
Copy link
Member

This PR fixes the previous fix: #4715

@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. bug Something isn't working labels Nov 21, 2024
@github-actions github-actions bot added bug Something isn't working and removed bug Something isn't working labels Nov 21, 2024
@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Nov 21, 2024 •
edited
Loading

CodSpeed Performance Report

Merging #4751 will degrade performances by 38.8%

Comparing fix/assign-orphaned-flows-rename (9515cc9) with main (be7eac9)

Summary

⚡ 2 improvements
❌ 2 regressions
✅ 11 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark main fix/assign-orphaned-flows-rename Change
⚡ test_create_starter_projects 1.5 s 1.3 s +22.34%
❌ test_successful_run_with_input_type_any 260.1 ms 324.1 ms -19.77%
❌ test_successful_run_with_input_type_text 140.9 ms 230.3 ms -38.8%
⚡ test_successful_run_with_output_type_debug 321 ms 268.7 ms +19.44%

@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. and removed size:M This PR changes 30-99 lines, ignoring generated files. labels Nov 21, 2024
ogabrielluiz
ogabrielluiz approved these changes Nov 21, 2024
View reviewed changes
Copy link
Contributor

@ogabrielluiz ogabrielluiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Nov 21, 2024
@ogabrielluiz ogabrielluiz enabled auto-merge (squash) November 21, 2024 13:53
@ogabrielluiz ogabrielluiz changed the title fix: ensure unique flow names when assigning to superuser fix: ensure unique flow names when assigning to superuser and avoid adding starter projects Nov 21, 2024
@github-actions github-actions bot added bug Something isn't working and removed bug Something isn't working labels Nov 21, 2024
@ogabrielluiz ogabrielluiz force-pushed the fix/assign-orphaned-flows-rename branch 2 times, most recently from 62f721a to e869b1a Compare November 21, 2024 14:24
@edwinjosechittilappilly
Copy link
Collaborator

@ogabrielluiz @italojohnny can we get this merged?

@italojohnny italojohnny force-pushed the fix/assign-orphaned-flows-rename branch from e869b1a to 61a7af4 Compare November 21, 2024 17:10
@ogabrielluiz ogabrielluiz force-pushed the fix/assign-orphaned-flows-rename branch from 61a7af4 to 9515cc9 Compare November 21, 2024 17:26
@ogabrielluiz ogabrielluiz merged commit e728e40 into main Nov 21, 2024
25 of 26 checks passed
@ogabrielluiz ogabrielluiz deleted the fix/assign-orphaned-flows-rename branch November 21, 2024 17:35
mieslep pushed a commit to mieslep/langflow that referenced this pull request Nov 22, 2024
@italojohnny @ogabrielluiz @mieslep
fix: ensure unique flow names when assigning to superuser and avoid a…
46fbddf 
…dding starter projects (langflow-ai#4751)

* fix: ensure unique flow names when assigning to superuser

* refactor: Creates a new function with logic to rename flows

* refactor: simplify function

* Extract STARTER_FOLDER constants to a separate module

* Filter orphaned flows by excluding those in the starter folder

---------

Co-authored-by: Gabriel Luiz Freitas Almeida <gabriel@langflow.org>
diogocabral pushed a commit to headlinevc/langflow that referenced this pull request Nov 26, 2024
@italojohnny @ogabrielluiz @diogocabral
fix: ensure unique flow names when assigning to superuser and avoid a…
1e88e49 
…dding starter projects (langflow-ai#4751)

* fix: ensure unique flow names when assigning to superuser

* refactor: Creates a new function with logic to rename flows

* refactor: simplify function

* Extract STARTER_FOLDER constants to a separate module

* Filter orphaned flows by excluding those in the starter folder

---------

Co-authored-by: Gabriel Luiz Freitas Almeida <gabriel@langflow.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ogabrielluiz ogabrielluiz ogabrielluiz approved these changes

Assignees
No one assigned
Labels
bug Something isn't working lgtm This PR has been approved by a maintainer size:L This PR changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@italojohnny @edwinjosechittilappilly @ogabrielluiz