Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Error in SerpAPI search: cannot access local variable 'wrapper' where it is not associated with a value #4758

Merged
merged 2 commits into from
Nov 22, 2024

Conversation

edwinjosechittilappilly
Copy link
Collaborator

fixes: Error: Error in SerpAPI search: cannot access local variable 'wrapper' where it is not associated with a value

Closes issue #4640

This pull request includes a small but important change to the build_tool method in the src/backend/base/langflow/components/tools/serp_api.py file. The change improves the handling of the wrapper variable to ensure that the original wrapper is not overwritten when new parameters are provided.

Codebase simplification:

fixes:  Error: Error in SerpAPI search: cannot access local variable 'wrapper' where it is not associated with a value
@dosubot dosubot bot added size:XS This PR changes 0-9 lines, ignoring generated files. bug Something isn't working labels Nov 21, 2024
@github-actions github-actions bot added bug Something isn't working and removed bug Something isn't working labels Nov 21, 2024
@edwinjosechittilappilly
Copy link
Collaborator Author

closes #4640

Copy link
Contributor

@ogabrielluiz ogabrielluiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Nov 21, 2024
@ogabrielluiz ogabrielluiz merged commit 8fb19ad into main Nov 22, 2024
33 of 34 checks passed
@ogabrielluiz ogabrielluiz deleted the fix-serp-api-tool branch November 22, 2024 00:44
mieslep pushed a commit to mieslep/langflow that referenced this pull request Nov 22, 2024
…where it is not associated with a value (langflow-ai#4758)

Update serp_api.py

fixes:  Error: Error in SerpAPI search: cannot access local variable 'wrapper' where it is not associated with a value
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working lgtm This PR has been approved by a maintainer size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants