feat: Support for Autodetect in AstraDBVectorStore settings #4869
+278
−91
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
the
size:L
github-actions
bot
added
enhancement
CodSpeed Performance ReportMerging #4869 will degrade performances by 55.69%Comparing Summary
Benchmarks breakdown
|
erichare
requested review from
edwinjosechittilappilly,
ogabrielluiz,
Cristhianzl and
cbornet
erichare
changed the title
github-actions
bot
added
enhancement
|
Hey @erichare Can we merge this? |
|
@ogabrielluiz i'm a little cautious about it, mostly because i'm not completely positive how the dropdown selector for collections conflicts with the ASTRA_ENHANCED functionality in DS LF. Unless there's a really good reason i'd lean towards maybe waiting on this, and i'll try to rally some testers of all the scenarios and we can get it merged next week? i'll be out most of today and tomorrow as well |
mieslep
pushed a commit
to mieslep/langflow
that referenced
this pull request
Dec 4, 2024
…-ai#4869) * feat: first pass at autodetect updates * [autofix.ci] apply automated fixes * Fully support autodetect --------- Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request [DO NOT MERGE] is a first pass at adding a much better user experience for existing collections, including
autodetectsupport in AstraDBVectorStore