Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feature: Improve Table customization to enhance ux on tool mode #5216

Merged
merged 31 commits into from
Dec 16, 2024
Merged

feature: Improve Table customization to enhance ux on tool mode #5216

merged 31 commits into from
Dec 16, 2024

Conversation

anovazzi1
Copy link
Contributor

This pr enhances the table options to enhance the toolmode view and configuration of components tool mode

@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. enhancement New feature or request labels Dec 11, 2024
@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Dec 11, 2024 •
edited
Loading

CodSpeed Performance Report

Merging #5216 will not alter performance

Comparing updateTableField (92e6e2a) with main (13a4680)

Summary

✅ 15 untouched benchmarks

lucaseduoli
lucaseduoli approved these changes Dec 12, 2024
View reviewed changes
Copy link
Collaborator

@lucaseduoli lucaseduoli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Dec 12, 2024
edwinjosechittilappilly
edwinjosechittilappilly approved these changes Dec 13, 2024
View reviewed changes
Copy link
Collaborator

@edwinjosechittilappilly edwinjosechittilappilly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@anovazzi1 @ogabrielluiz
refactor: Add field validation options to TableOptions
48f89af
@anovazzi1 @ogabrielluiz
refactor: Add field validation options and trigger text/icon to Table…
7922b06 
…Mixin
@anovazzi1 @ogabrielluiz
refactor: Add field validation options and trigger text/icon to Table…
2feb3ae 
…Mixin
@anovazzi1 @ogabrielluiz
refactor: Add field validation options and trigger text/icon to Table…
0c01a10 
…Mixin
@anovazzi1 @ogabrielluiz
update table trigger for toolmode usage
6165527
@anovazzi1 @ogabrielluiz
Refactor table trigger and field validation options
da3c4f1 
- Updated the table trigger for toolmode usage
- Added field validation options and trigger text/icon to TableMixin
- Modified TableOptions to block certain actions and hide options
@anovazzi1 @ogabrielluiz
Refactor TableOptionsTypeAPI field names for blocking actions
d057197
@anovazzi1 @ogabrielluiz
Refactor TableOptions default values for blocking actions
0135ca2
@anovazzi1 @ogabrielluiz
Refactor TableOptions default values for blocking actions
9020444
@anovazzi1 @ogabrielluiz
Refactor TableOptions component to include tableOptions prop
dc3dd85
@anovazzi1 @ogabrielluiz
Refactor table selection and pagination options
b1ec84b
@anovazzi1 @ogabrielluiz
Refactor TOOL_TABLE_SCHEMA to disable sorting and filtering for the "…
ce240ca 
…name" and "description" fields
@anovazzi1 @ogabrielluiz
Refactor TableOptions to allow blocking hiding of fields
c474955
@anovazzi1 @ogabrielluiz
Refactor TableModal and TableNodeComponent to include support for blo…
9040bfc 
…ck hiding columns
@anovazzi1 @ogabrielluiz
Refactor Column model to include support for different edit modes
0f5f001
@anovazzi1 @ogabrielluiz
Refactor TableOptions to include support for field parsers
26b1063
@anovazzi1 @ogabrielluiz
Refactor TableOptions to include support for field parsers and blocki…
c7323b9 
…ng hiding of fields
@anovazzi1 @ogabrielluiz
Refactor TableOptions to include support for inline editing of fields
f37d3db
@anovazzi1 @ogabrielluiz
Refactor App.css to style large text inputs and text areas in AgGrid
96378a6
@anovazzi1 @ogabrielluiz
update types
291e0a6
@edwinjosechittilappilly edwinjosechittilappilly mentioned this pull request Dec 16, 2024
Merged
@ogabrielluiz ogabrielluiz enabled auto-merge (squash) December 16, 2024 17:40
@ogabrielluiz ogabrielluiz merged commit dffc2d5 into main Dec 16, 2024
36 checks passed
@ogabrielluiz ogabrielluiz deleted the updateTableField branch December 16, 2024 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edwinjosechittilappilly edwinjosechittilappilly edwinjosechittilappilly approved these changes

@lucaseduoli lucaseduoli lucaseduoli approved these changes

@ogabrielluiz ogabrielluiz Awaiting requested review from ogabrielluiz

Assignees
No one assigned
Labels
enhancement New feature or request lgtm This PR has been approved by a maintainer size:L This PR changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@anovazzi1 @edwinjosechittilappilly @lucaseduoli @ogabrielluiz