Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add vector retrieval and update policy/template #5218

Merged
merged 25 commits into from
Dec 18, 2024

Conversation

pedrocassalpacheco
Copy link
Contributor

@pedrocassalpacheco pedrocassalpacheco commented Dec 11, 2024

This modifies the module configuration to reflect the proper class name, modifies the AstraDBGraphVectorComponent to support different search algorithms, and fixes the JSON parsing for the index policy property. It also adds a template for Graph RAG.

@dosubot dosubot bot added the size:XL This PR changes 500-999 lines, ignoring generated files. label Dec 11, 2024
Copy link
Contributor

@ogabrielluiz ogabrielluiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @pedrocassalpacheco

Thanks for the improvements.
Could you review the PR title to conform with conventional commits (https://www.conventionalcommits.org/en/v1.0.0/#summary) ?

Copy link

codspeed-hq bot commented Dec 12, 2024

CodSpeed Performance Report

Merging #5218 will degrade performances by 10.65%

Comparing pedrocassalpacheco:main (7863eb8) with main (13a4680)

Summary

❌ 1 regressions
✅ 14 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark main pedrocassalpacheco:main Change
test_successful_run_with_output_type_any 228.2 ms 255.4 ms -10.65%

@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. and removed size:XL This PR changes 500-999 lines, ignoring generated files. labels Dec 12, 2024
@pedrocassalpacheco pedrocassalpacheco changed the title Support for Graph Vector retrieval, small improvements around collection policy and template feat: Added support for graph vector retrieval, small improvements around collection policy and template Dec 12, 2024
@github-actions github-actions bot added the enhancement New feature or request label Dec 12, 2024
@pedrocassalpacheco pedrocassalpacheco changed the title feat: Added support for graph vector retrieval, small improvements around collection policy and template feat: add vector retrieval and update policy/template Dec 13, 2024
@github-actions github-actions bot removed the enhancement New feature or request label Dec 13, 2024
@github-actions github-actions bot added enhancement New feature or request and removed enhancement New feature or request labels Dec 13, 2024
@pedrocassalpacheco
Copy link
Contributor Author

Hey @pedrocassalpacheco

Thanks for the improvements. Could you review the PR title to conform with conventional commits (https://www.conventionalcommits.org/en/v1.0.0/#summary) ?

@ogabrielluiz - can you review this again? I think I addressed your concerns ...

@github-actions github-actions bot added enhancement New feature or request and removed enhancement New feature or request labels Dec 16, 2024
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Dec 16, 2024
@github-actions github-actions bot added enhancement New feature or request and removed enhancement New feature or request labels Dec 16, 2024
…aph.json

Remove template as per langflow team
@github-actions github-actions bot added enhancement New feature or request and removed enhancement New feature or request labels Dec 17, 2024
@pedrocassalpacheco
Copy link
Contributor Author

@ogabrielluiz - I removed the template from the PR as requested

@ogabrielluiz ogabrielluiz enabled auto-merge (squash) December 18, 2024 01:47
@github-actions github-actions bot added enhancement New feature or request and removed enhancement New feature or request labels Dec 18, 2024
@ogabrielluiz ogabrielluiz added this pull request to the merge queue Dec 18, 2024
Merged via the queue into langflow-ai:main with commit b98b225 Dec 18, 2024
34 checks passed
anovazzi1 pushed a commit that referenced this pull request Dec 19, 2024
* Updated collection_indexing_policy to store the correct json. Added support for graph retrival and other minor imporvements

* Added RagGraph template

* [autofix.ci] apply automated fixes

* Corrected the class name to avoid ut failures

* [autofix.ci] apply automated fixes

* Updated _map_search_type to be less idiotic

* [autofix.ci] apply automated fixes

* [autofix.ci] apply automated fixes (attempt 2/3)

* Renamed AstraDBGraphVectorStoreComponent back to its original form for convention sake

* Unrelated to the graph work

* [autofix.ci] apply automated fixes

* [autofix.ci] apply automated fixes (attempt 2/3)

* Linting

* [autofix.ci] apply automated fixes

* [autofix.ci] apply automated fixes (attempt 2/3)

* [autofix.ci] apply automated fixes

* Delete src/backend/base/langflow/initial_setup/starter_projects/RagGraph.json

Remove template as per langflow team

---------

Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
Co-authored-by: Eric Hare <ericrhare@gmail.com>
Co-authored-by: Gabriel Luiz Freitas Almeida <gabriel@langflow.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request lgtm This PR has been approved by a maintainer size:M This PR changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants