Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: ArizePhoenixTracer v2 - Enhanced Session Tracking and Flow Organization #5336

Merged

Conversation

ialisaleh
Copy link
Contributor

This PR introduces v2 of the ArizePhoenixTracer, significantly enhancing session tracing and Arize/Phoenix integration.

Key Improvements:

Per-Flow Projects: Each flow now creates a dedicated project in Arize/Phoenix for better tracking and organization.
Enhanced Root Span: Added session IDs, input blocks, and output blocks to capture detailed session-level insights.
Simplified Tracing: Removed unnecessary session IDs from individual component spans to reduce complexity and noise.
Codebase Refactor: Improved readability and maintainability through modularization and cleanup.

These updates streamline observability, improve integration, and enhance the overall user experience.

@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. enhancement New feature or request labels Dec 18, 2024
@github-actions github-actions bot added enhancement New feature or request and removed enhancement New feature or request labels Dec 18, 2024
@ogabrielluiz ogabrielluiz requested a review from Copilot December 18, 2024 15:48
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.

Comments suppressed due to low confidence (2)

src/backend/base/langflow/services/tracing/arize_phoenix.py:214

  • Ensure processed_inputs contains the key 'input_value' to avoid potential KeyErrors.
self.chat_input_value = processed_inputs["input_value"]

src/backend/base/langflow/services/tracing/arize_phoenix.py:275

  • Ensure the new _set_span_status method is covered by tests.
self._set_span_status(self.root_span, error)

Copy link

codspeed-hq bot commented Dec 18, 2024

CodSpeed Performance Report

Merging #5336 will degrade performances by 22.82%

Comparing ialisaleh:feat/arize-phoenix-tracer-v2 (b7828f3) with main (5a8d73c)

Summary

⚡ 1 improvements
❌ 1 regressions
✅ 13 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark main ialisaleh:feat/arize-phoenix-tracer-v2 Change
test_setup_llm_caching 2.1 ms 1.2 ms +82.05%
test_successful_run_with_output_type_any 248.2 ms 321.6 ms -22.82%

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Dec 18, 2024
@ogabrielluiz ogabrielluiz added this pull request to the merge queue Dec 18, 2024
Merged via the queue into langflow-ai:main with commit 82080eb Dec 18, 2024
32 of 40 checks passed
anovazzi1 pushed a commit that referenced this pull request Dec 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request lgtm This PR has been approved by a maintainer size:L This PR changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants