Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: adds test cases for loop component compatibility with the APIs, Loop component updates to support API #5615

Merged
merged 28 commits into from
Jan 14, 2025

Conversation

edwinjosechittilappilly
Copy link
Collaborator

@edwinjosechittilappilly edwinjosechittilappilly commented Jan 9, 2025

This pull request includes significant changes to the LoopComponent class and its associated tests. The most important changes include refactoring the initialize_data method, adding new methods for loop control, and updating the test configurations and fixtures.

Refactoring and new methods in LoopComponent:

Test configuration and fixtures:

New test cases for LoopComponent:

Additional method in CustomComponent:

@edwinjosechittilappilly edwinjosechittilappilly marked this pull request as ready for review January 9, 2025 20:14
@dosubot dosubot bot added the size:XXL This PR changes 1000+ lines, ignoring generated files. label Jan 9, 2025
@github-actions github-actions bot added the enhancement New feature or request label Jan 9, 2025
@edwinjosechittilappilly edwinjosechittilappilly changed the title feat: add test cases for loop component tests with the API feat: adds test cases for loop component compatibility with the APIs Jan 9, 2025
@github-actions github-actions bot added enhancement New feature or request and removed enhancement New feature or request labels Jan 9, 2025
Copy link
Contributor

@ogabrielluiz ogabrielluiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you take a look at the TestBatchRunComponent test and build these tests using the same structure?

@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. and removed size:XXL This PR changes 1000+ lines, ignoring generated files. labels Jan 10, 2025
@github-actions github-actions bot added enhancement New feature or request and removed enhancement New feature or request labels Jan 10, 2025
Copy link

codspeed-hq bot commented Jan 10, 2025

CodSpeed Performance Report

Merging #5615 will degrade performances by 49.6%

Comparing fix-loop (df3cefd) with main (43d22fd)

Summary

❌ 1 regressions
✅ 14 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark main fix-loop Change
test_get_and_cache_all_types_dict 1.1 ms 2.1 ms -49.6%

@github-actions github-actions bot added enhancement New feature or request and removed enhancement New feature or request labels Jan 10, 2025
@github-actions github-actions bot added enhancement New feature or request and removed enhancement New feature or request labels Jan 13, 2025
@edwinjosechittilappilly edwinjosechittilappilly changed the title feat: adds test cases for loop component compatibility with the APIs feat: adds test cases for loop component compatibility with the APIs, Loop component updates to support API Jan 13, 2025
@github-actions github-actions bot added enhancement New feature or request and removed enhancement New feature or request labels Jan 13, 2025
@github-actions github-actions bot added enhancement New feature or request and removed enhancement New feature or request labels Jan 13, 2025
@github-actions github-actions bot added enhancement New feature or request and removed enhancement New feature or request labels Jan 13, 2025
@github-actions github-actions bot added enhancement New feature or request and removed enhancement New feature or request labels Jan 14, 2025
@github-actions github-actions bot added enhancement New feature or request and removed enhancement New feature or request labels Jan 14, 2025
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Jan 14, 2025
@github-actions github-actions bot added enhancement New feature or request and removed enhancement New feature or request labels Jan 14, 2025
@edwinjosechittilappilly edwinjosechittilappilly merged commit 8ebe580 into loop-component Jan 14, 2025
8 checks passed
@edwinjosechittilappilly edwinjosechittilappilly deleted the fix-loop branch January 14, 2025 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request lgtm This PR has been approved by a maintainer size:XXL This PR changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants