Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fixes AgentExecutor handle greyed out #5900

Merged
merged 2 commits into from
Jan 27, 2025
Merged

Conversation

edwinjosechittilappilly
Copy link
Collaborator

This pull request includes updates to the src/frontend/src/utils/styleUtils.ts file to add color mappings for the AgentExecutor node.

Changes to color mappings:

@dosubot dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Jan 23, 2025
@github-actions github-actions bot added the bug Something isn't working label Jan 23, 2025
@edwinjosechittilappilly
Copy link
Collaborator Author

@Cristhianzl @ogabrielluiz can you review this color? I used the same color as Agent.

But looks similar to language models.

Screenshot 2025-01-23 at 2 54 35 PM

@edwinjosechittilappilly
Copy link
Collaborator Author

@Cristhianzl feel free to edit the PR.

@edwinjosechittilappilly edwinjosechittilappilly changed the title fix: AgentExecutor Bubble fix: fixes AgentExecutor Bubble greyed out . Jan 23, 2025
@github-actions github-actions bot added bug Something isn't working and removed bug Something isn't working labels Jan 23, 2025
@edwinjosechittilappilly edwinjosechittilappilly changed the title fix: fixes AgentExecutor Bubble greyed out . fix: fixes AgentExecutor Bubble greyed out Jan 23, 2025
@github-actions github-actions bot added bug Something isn't working and removed bug Something isn't working labels Jan 23, 2025
@edwinjosechittilappilly
Copy link
Collaborator Author

edwinjosechittilappilly commented Jan 23, 2025

Screenshot 2025-01-23 at 3 03 31 PM

@Cristhianzl suggestion why the input color is still the same?

Output color of AgentExecutor type got updated.

…urple-foreground to improve design consistency
@github-actions github-actions bot added bug Something isn't working and removed bug Something isn't working labels Jan 23, 2025
Copy link
Member

@Cristhianzl Cristhianzl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

we just fixed the purple color on dark mode.

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Jan 23, 2025
@ogabrielluiz ogabrielluiz changed the title fix: fixes AgentExecutor Bubble greyed out fix: fixes AgentExecutor handle greyed out Jan 27, 2025
@ogabrielluiz ogabrielluiz added this pull request to the merge queue Jan 27, 2025
@github-actions github-actions bot added bug Something isn't working and removed bug Something isn't working labels Jan 27, 2025
Merged via the queue into main with commit 410d16f Jan 27, 2025
32 of 33 checks passed
@ogabrielluiz ogabrielluiz deleted the fix-agent-bubble-color branch January 27, 2025 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working lgtm This PR has been approved by a maintainer size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants