fix: re-add removed variable + fix documentation #5902
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
size:XS
github-actions
bot
added
bug
mollux
force-pushed
the
fix/docker-documentation
branch
from
acf04e0 to
e6074b8
Compare
github-actions
bot
added
bug
mollux
force-pushed
the
fix/docker-documentation
branch
from
e6074b8 to
4314d3b
Compare
github-actions
bot
added
bug
italojohnny
approved these changes
Jan 28, 2025
github-actions
bot
added
bug
ogabrielluiz
removed this pull request from the merge queue due to the queue being cleared
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is currently a mismatch between the example
docker-compose.ymlfile and the documentation about the 'config' dir:/var/lib/langflowis mapped, but the example compose files uses/app/langflowLANGFLOW_CONFIG_DIRis no longer specified (this was deleted in chore: simplify docker #2526, not clear why), so langflow defaults to/app/data/.cache(based on the homedir of the user.)This could also result in data loss (database, secret key, ...) when the container is removed (e.g. when running
docker compose down)In general it's very strange that a cache dir is used to store vital data and information to keep an app running, but that's for another PR :)