-
Notifications
You must be signed in to change notification settings - Fork 7.3k
fix: don't require embedding model in case astra db token lacks perms #5926
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CodSpeed Performance ReportMerging #5926 will improve performances by ×24Comparing Summary
Benchmarks breakdown
|
codeflash-ai bot
added a commit
that referenced
this pull request
Jan 26, 2025
…tic` by 30% in PR #5926 (`fix-astradb-vectorize`) These changes should enhance the runtime performance of the function by reducing the overhead of redundant API calls and minimizing repetitive operations.
codeflash-ai bot
added a commit
that referenced
this pull request
Jan 26, 2025
…by 54% in PR #5926 (`fix-astradb-vectorize`) The code optimizes the update_build_config method by leveraging caching and reducing repeated calls to the same methods. This is aimed at minimizing the latency involved in fetching data from external sources and improving overall performance.
codeflash-ai bot
added a commit
that referenced
this pull request
Jan 27, 2025
…by 18% in PR #5926 (`fix-astradb-vectorize`) To improve the performance and efficiency of the provided Python program, we'll make a few adjustments that focus on minimizing redundant operations and streamlining logic, where possible. ### Summary of Changes for Performance Improvement. These optimizations focus on making the code not just more efficient but also more readable and maintainable.
ogabrielluiz
approved these changes
Jan 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request addresses permission issues with Astra DB Application Tokens that may lead to unexpected behavior in the Astra DB Component. Specifically: