Skip to content

fix: don't require embedding model in case astra db token lacks perms #5926

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 26 commits into from
Jan 27, 2025

Conversation

erichare
Copy link
Collaborator

@erichare erichare commented Jan 25, 2025

This pull request addresses permission issues with Astra DB Application Tokens that may lead to unexpected behavior in the Astra DB Component. Specifically:

  1. It does not explicitly require providing an Embedding Model - at runtime, the error will alert the user if one is required for non-vectorize collections
  2. It handles the scenario where a user has multiple databases, but a token scoped to a single database, in which the app will be unable to load collection information about the database. Now, the component will skip the unscoped database(s) and correctly load information about the DBs that the token are scoped to.
  3. It updates the Vector Store RAG template to use the newest version of the component, and has been verified to correctly operate with Vectorize collections.

@dosubot dosubot bot added size:XS This PR changes 0-9 lines, ignoring generated files. bug Something isn't working labels Jan 25, 2025
@github-actions github-actions bot added bug Something isn't working and removed bug Something isn't working labels Jan 25, 2025
@github-actions github-actions bot added bug Something isn't working and removed bug Something isn't working labels Jan 25, 2025
Copy link

codspeed-hq bot commented Jan 25, 2025

CodSpeed Performance Report

Merging #5926 will improve performances by ×24

Comparing fix-astradb-vectorize (89a33de) with main (5c64e59)

Summary

⚡ 1 improvements
✅ 8 untouched benchmarks

Benchmarks breakdown

Benchmark BASE HEAD Change
test_successful_run_with_input_type_any 4,163.7 ms 170.6 ms ×24

@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. and removed size:XS This PR changes 0-9 lines, ignoring generated files. labels Jan 25, 2025
@github-actions github-actions bot added bug Something isn't working and removed bug Something isn't working labels Jan 25, 2025
@github-actions github-actions bot added bug Something isn't working and removed bug Something isn't working labels Jan 25, 2025
@github-actions github-actions bot added bug Something isn't working and removed bug Something isn't working labels Jan 25, 2025
@github-actions github-actions bot added bug Something isn't working and removed bug Something isn't working labels Jan 25, 2025
@github-actions github-actions bot added bug Something isn't working and removed bug Something isn't working labels Jan 25, 2025
@github-actions github-actions bot added bug Something isn't working and removed bug Something isn't working labels Jan 25, 2025
@erichare erichare requested a review from ogabrielluiz January 25, 2025 16:25
@github-actions github-actions bot added bug Something isn't working and removed bug Something isn't working labels Jan 26, 2025
codeflash-ai bot added a commit that referenced this pull request Jan 26, 2025
…tic` by 30% in PR #5926 (`fix-astradb-vectorize`)

These changes should enhance the runtime performance of the function by reducing the overhead of redundant API calls and minimizing repetitive operations.
codeflash-ai bot added a commit that referenced this pull request Jan 26, 2025
…by 54% in PR #5926 (`fix-astradb-vectorize`)

The code optimizes the update_build_config method by leveraging caching and reducing repeated calls to the same methods. This is aimed at minimizing the latency involved in fetching data from external sources and improving overall performance.
@github-actions github-actions bot added bug Something isn't working and removed bug Something isn't working labels Jan 26, 2025
@github-actions github-actions bot added bug Something isn't working and removed bug Something isn't working labels Jan 26, 2025
@github-actions github-actions bot added bug Something isn't working and removed bug Something isn't working labels Jan 26, 2025
@github-actions github-actions bot added bug Something isn't working and removed bug Something isn't working labels Jan 26, 2025
@github-actions github-actions bot added bug Something isn't working and removed bug Something isn't working labels Jan 27, 2025
@github-actions github-actions bot added bug Something isn't working and removed bug Something isn't working labels Jan 27, 2025
codeflash-ai bot added a commit that referenced this pull request Jan 27, 2025
…by 18% in PR #5926 (`fix-astradb-vectorize`)

To improve the performance and efficiency of the provided Python program, we'll make a few adjustments that focus on minimizing redundant operations and streamlining logic, where possible.

### Summary of Changes for Performance Improvement.

These optimizations focus on making the code not just more efficient but also more readable and maintainable.
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Jan 27, 2025
@ogabrielluiz ogabrielluiz added this pull request to the merge queue Jan 27, 2025
Merged via the queue into main with commit f84033f Jan 27, 2025
44 of 45 checks passed
@ogabrielluiz ogabrielluiz deleted the fix-astradb-vectorize branch January 27, 2025 12:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working lgtm This PR has been approved by a maintainer size:L This PR changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants