Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove reference to a non-existent method in NvidiaRerankComponent #5957

Merged
merged 1 commit into from
Jan 27, 2025

Conversation

ogabrielluiz
Copy link
Contributor

Fixes #5934

@dosubot dosubot bot added size:XS This PR changes 0-9 lines, ignoring generated files. bug Something isn't working labels Jan 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.

Comments suppressed due to low confidence (1)

src/backend/base/langflow/components/nvidia/nvidia_rerank.py:56

  • Ensure that the object returned by build_reranker() has an available_models attribute. If it doesn't, this change will cause an error.
build_model = self.build_reranker()
@github-actions github-actions bot added bug Something isn't working and removed bug Something isn't working labels Jan 27, 2025
Copy link
Contributor

@anovazzi1 anovazzi1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Jan 27, 2025
@ogabrielluiz ogabrielluiz added this pull request to the merge queue Jan 27, 2025
Merged via the queue into main with commit ea2685f Jan 27, 2025
42 of 51 checks passed
@ogabrielluiz ogabrielluiz deleted the fix-nvidia-buildmodel branch January 27, 2025 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working lgtm This PR has been approved by a maintainer size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

NVIDIA reranker undefined build_model method
3 participants