fix: Improve error handling at startup #5994
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Catch and handle potential network connection errors when attempting to build the version notice, preventing potential startup failures due to version check issues
Enhance version notice function by: - Adding comprehensive docstring with description, args, returns, and example - Using contextlib.suppress to handle network errors - Removing redundant try-except block in print_banner - Simplifying version check logic
Change telemetry service error logging from `logger.exception()` to `logger.error()` to reduce verbosity and prevent unnecessary stack trace printing
Remove unused logger import and exception logging in version check function to simplify error handling and reduce unnecessary logging
dosubot
bot
added
size:S
There was a problem hiding this comment.
Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.
Comments suppressed due to low confidence (2)
src/backend/base/langflow/main.py:370
- Ensure that
package_nameis found innoticebefore callingstylize_textto avoid unexpected behavior.
notice = stylize_text(notice, package_name, is_prerelease=is_pre_release)
src/backend/base/langflow/main.py:330
- Update the example in the docstring to reflect that the function may return an empty string if no newer version is available.
>>> build_version_notice("1.0.0", "langflow")
github-actions
bot
added
bug
dosubot
bot
added
size:M
github-actions
bot
added
bug
There was a problem hiding this comment.
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
Comments suppressed due to low confidence (4)
src/backend/base/langflow/utils/version.py:87
- Removing logger.exception hides errors that occur during the fetching process, making it harder to diagnose issues. Consider keeping some form of logging to capture these errors.
return None
src/backend/base/langflow/services/telemetry/service.py:75
- [nitpick] Changing from logger.exception to logger.error reduces the amount of information available for debugging. Confirm if this reduction in logging detail is intentional and won't impact debugging.
logger.error("HTTP error occurred")
src/backend/base/langflow/services/telemetry/service.py:77
- [nitpick] Changing from logger.exception to logger.error reduces the amount of information available for debugging. Confirm if this reduction in logging detail is intentional and won't impact debugging.
logger.error("Request error occurred")
src/backend/base/langflow/services/telemetry/service.py:79
- [nitpick] Changing from logger.exception to logger.error reduces the amount of information available for debugging. Confirm if this reduction in logging detail is intentional and won't impact debugging.
logger.error("Unexpected error occurred")
|
I'll send you a suggestion on dm! |
ogabrielluiz
deleted the
5327-langflow-does-not-start-in-airgapped-environment-despite-setting-do_not_tracktrue
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enhance the robustness of API requests by adding comprehensive error handling and logging mechanisms. This change aims to provide clearer feedback during failures and improve overall user experience.