Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: improve artifact type handling and result processing #6002

Merged
merged 1 commit into from
Jan 29, 2025

Conversation

Cristhianzl
Copy link
Member

@Cristhianzl Cristhianzl commented Jan 29, 2025

This pull request includes several changes to improve the handling and processing of artifacts in the backend. The most important changes involve modifying the logic for determining the artifact type, updating the raw result processing, and refactoring the post-processing of raw data.

Improvements to artifact type determination and raw result processing:

Refactoring of post-processing logic:

  • src/backend/base/langflow/schema/artifact.py: Added a default_message variable to store the default success message. Refactored the post_process_raw method to use this variable instead of hardcoding the message, enhancing maintainability and readability. [1] [2]

Language Model Output View:

image

…on raw data and status

🐛 (artifact.py): fix the default message assignment in post_process_raw function to ensure consistent behavior
@Cristhianzl Cristhianzl self-assigned this Jan 29, 2025
@dosubot dosubot bot added the size:S This PR changes 10-29 lines, ignoring generated files. label Jan 29, 2025
@github-actions github-actions bot added refactor Maintenance tasks and housekeeping and removed refactor Maintenance tasks and housekeeping labels Jan 29, 2025
Copy link
Contributor

@ogabrielluiz ogabrielluiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Jan 29, 2025
@ogabrielluiz ogabrielluiz added this pull request to the merge queue Jan 29, 2025
Merged via the queue into main with commit 7e756b9 Jan 29, 2025
35 of 36 checks passed
@ogabrielluiz ogabrielluiz deleted the cz/fix-output-models branch January 29, 2025 19:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm This PR has been approved by a maintainer refactor Maintenance tasks and housekeeping size:S This PR changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants