Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Correctly update reactive form on hosted instances #6023

Merged
merged 4 commits into from
Jan 30, 2025

Conversation

erichare
Copy link
Collaborator

This pull request adds one additional check to allow reactivity to be correctly supported on DataStax Langflow-hosted instances.

@dosubot dosubot bot added the size:S This PR changes 10-29 lines, ignoring generated files. label Jan 30, 2025
@erichare erichare changed the title fix: Update reactive form on hosted dslf fix: Correctly update reactive form on hosted instances Jan 30, 2025
@erichare erichare requested a review from Cristhianzl January 30, 2025 14:48
@github-actions github-actions bot added bug Something isn't working and removed bug Something isn't working labels Jan 30, 2025
@github-actions github-actions bot added bug Something isn't working and removed bug Something isn't working labels Jan 30, 2025
Copy link
Member

@Cristhianzl Cristhianzl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Jan 30, 2025
codeflash-ai bot added a commit that referenced this pull request Jan 30, 2025
…by 28% in PR #6023 (`fix-dslf-reactivity`)

Here's the optimized version of the provided `AstraDBVectorStoreComponent` class. The primary focus of the optimization is reducing the overhead and improving the efficiency of the methods by minimizing repeated operations, and handling exceptions more selectively.



### Changes Made.
1. **Use Local Variables for List and Dict Values:** Extracted list and dict values to a local variable to avoid redundant access.
2. **Centralized Exception Handling:** Removed the separate exception block from `_initialize_collection_options` and handled it more gracefully in a single try-except block.
3. **Refactored Redundant Operations:** Grouped related operations to reduce redundancy, especially where the build configuration is updated based on the field name.

These improvements help in making the code faster by reducing repeated operations and minimizing the exception handling overheads while maintaining readability and functionality.
@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. and removed size:S This PR changes 10-29 lines, ignoring generated files. labels Jan 30, 2025
@github-actions github-actions bot added bug Something isn't working and removed bug Something isn't working labels Jan 30, 2025
@github-actions github-actions bot added bug Something isn't working and removed bug Something isn't working labels Jan 30, 2025
@ogabrielluiz ogabrielluiz added this pull request to the merge queue Jan 30, 2025
Merged via the queue into main with commit 311b5b3 Jan 30, 2025
36 checks passed
@ogabrielluiz ogabrielluiz deleted the fix-dslf-reactivity branch January 30, 2025 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working lgtm This PR has been approved by a maintainer size:M This PR changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants