Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Update dependencies to add smolagents package #6030

Merged
merged 8 commits into from
Feb 13, 2025
Merged

feat: Update dependencies to add smolagents package #6030

merged 8 commits into from
Feb 13, 2025

Conversation

ogabrielluiz
Copy link
Contributor

Update Pillow, Pandas, and NVIDIA AI Endpoints to their latest patch versions, and include the smolagents dependency in the project requirements.

@dosubot dosubot bot added size:XS This PR changes 0-9 lines, ignoring generated files. enhancement New feature or request labels Jan 30, 2025
@github-actions github-actions bot added enhancement New feature or request and removed enhancement New feature or request labels Jan 30, 2025
@ogabrielluiz
feat: Add HuggingFace model bridge for LangChain integration
09a123f 
Implement a model bridge that allows seamless conversion between LangChain and HuggingFace model interfaces, supporting message and tool call translations
@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. and removed size:XS This PR changes 0-9 lines, ignoring generated files. labels Jan 30, 2025
@github-actions github-actions bot added enhancement New feature or request and removed enhancement New feature or request labels Jan 30, 2025
@edwinjosechittilappilly
Copy link
Collaborator

Testing in Progress!

edwinjosechittilappilly
edwinjosechittilappilly requested changes Jan 30, 2025
View reviewed changes
Copy link
Collaborator

@edwinjosechittilappilly edwinjosechittilappilly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need Further testing,

NVIDIA LLMs seems to fail due to missing packages.

@github-actions github-actions bot added enhancement New feature or request and removed enhancement New feature or request labels Jan 31, 2025
@edwinjosechittilappilly
Copy link
Collaborator

I believe the NVIDIA update is causing issues.
Can you take a look at it? After that fix, it's good to merge!

@edwinjosechittilappilly
Copy link
Collaborator

edwinjosechittilappilly commented Feb 12, 2025 •
edited
Loading

@ogabrielluiz, do we need this for the current release?

This would be a wonderful add-on, especially since I like the functions to convert LC tools to HF tools and LC models compatible with SMOL.

This Has wider potential I believe

@edwinjosechittilappilly edwinjosechittilappilly mentioned this pull request Feb 13, 2025
Open
@edwinjosechittilappilly
Copy link
Collaborator

@ogabrielluiz, can you update this branch and merge #6323 into this branch?

During testing, I found that a few changes need to be made to the tool name to make it work with SMOL.
Also, in #6323, I have added a small SMOL component for the initial release/ test.

@github-actions github-actions bot added enhancement New feature or request and removed enhancement New feature or request labels Feb 13, 2025
@github-actions github-actions bot added enhancement New feature or request and removed enhancement New feature or request labels Feb 13, 2025
@ogabrielluiz
Copy link
Contributor Author

ogabrielluiz commented Feb 13, 2025 •
edited
Loading

@edwinjosechittilappilly what issues have you found in NVIDIA components? I didn't find any (apart from a misnamed field).

@edwinjosechittilappilly
Copy link
Collaborator

edwinjosechittilappilly commented Feb 13, 2025 •
edited
Loading

Its all good now.

edwinjosechittilappilly
edwinjosechittilappilly approved these changes Feb 13, 2025
View reviewed changes
Copy link
Collaborator

@edwinjosechittilappilly edwinjosechittilappilly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Feb 13, 2025
@github-actions github-actions bot added enhancement New feature or request and removed enhancement New feature or request labels Feb 13, 2025
@ogabrielluiz ogabrielluiz added this pull request to the merge queue Feb 13, 2025
Merged via the queue into main with commit 70e8650 Feb 13, 2025
24 checks passed
@ogabrielluiz ogabrielluiz deleted the bump-nidia-ai-endpoints branch February 13, 2025 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edwinjosechittilappilly edwinjosechittilappilly edwinjosechittilappilly approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request lgtm This PR has been approved by a maintainer size:L This PR changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ogabrielluiz @edwinjosechittilappilly